From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWkT6-0004fz-RV for qemu-devel@nongnu.org; Sat, 14 Mar 2015 07:43:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWkT3-0007tE-JZ for qemu-devel@nongnu.org; Sat, 14 Mar 2015 07:43:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40894 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWkT3-0007t2-Cn for qemu-devel@nongnu.org; Sat, 14 Mar 2015 07:42:57 -0400 Message-ID: <55041EBD.90601@suse.de> Date: Sat, 14 Mar 2015 12:42:53 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426273797-11204-1-git-send-email-ehabkost@redhat.com> <5503399F.5040307@suse.de> <20150313194518.GI3513@thinpad.lan.raisama.net> In-Reply-To: <20150313194518.GI3513@thinpad.lan.raisama.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] target-i386: Haswell-noTSX and Broadwell-noTSX CPU models List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, qemu-devel@nongnu.org, donald.d.dugger@intel.com, jun.nakajima@intel.com, Paolo Bonzini , Jiri Denemark Am 13.03.2015 um 20:45 schrieb Eduardo Habkost: > On Fri, Mar 13, 2015 at 08:25:19PM +0100, Andreas F=E4rber wrote: >> Only thing that comes to mind is whether it might make sense to >> hierarchically make Broadwell the parent type of Broadwell-noTSX, to >> avoid duplication. But then again we already have a lot of it. ;) >=20 > The builtin_x86_defs[] table has no way to represent inheritance, > currently. Maybe one day when we move everything inside class_init > functions. :) If x86_cpu_compat_set_features(), x86_cpu_list() and arch_query_cpu_definitions() get fixed to no longer operate on the old builtin_x86_defs[] but on object_class_foreach() or similar functions, then you can register special CPU types in x86_cpu_register_types(), like we do for the KVM host type already. In this case I imagined a custom class_init with an &=3D ~... operation. But I wasn't aware we're still using the array in so many places! :/ Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)