From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXQ9l-0001kC-Ai for qemu-devel@nongnu.org; Mon, 16 Mar 2015 04:13:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXQ9h-000080-Qr for qemu-devel@nongnu.org; Mon, 16 Mar 2015 04:13:49 -0400 Sender: Paolo Bonzini Message-ID: <550690B4.7000506@redhat.com> Date: Mon, 16 Mar 2015 09:13:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426326454-7216-1-git-send-email-zhaoshenglong@huawei.com> <55040865.8050908@weilnetz.de> <55054F1D.2080408@redhat.com> <55055DBA.9040804@msgid.tls.msk.ru> <55059324.8030202@redhat.com> <87a8zd4cy7.fsf@blackfin.pond.sub.org> In-Reply-To: <87a8zd4cy7.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, qemu-trivial@nongnu.org, Stefan Weil , Michael Tokarev , qemu-devel@nongnu.org, peter.huangpeng@huawei.com, shannon.zhao@linaro.org, Shannon Zhao On 16/03/2015 08:29, Markus Armbruster wrote: > > Well, in this case the bug in bt_l2cap_sdp_close_ch is much worse than a > > resource leak. But bluetooth is not the utmost priority in QEMU > > development... > > To put it more bluntly: it's rotting in peace. > > Occasional drive-by fixes won't stop the rot, a dedicated maintener > could. I disagree. The code is not that good, but apparently it works. Samsung folks are using it and presented their work at KVM Forum 2014. Paolo