From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXWHc-0004OD-9W for qemu-devel@nongnu.org; Mon, 16 Mar 2015 10:46:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXWHX-00075q-Tj for qemu-devel@nongnu.org; Mon, 16 Mar 2015 10:46:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXWHX-00075k-L6 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 10:46:15 -0400 Message-ID: <5506EC8B.1020300@redhat.com> Date: Mon, 16 Mar 2015 08:45:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426501911-1402-1-git-send-email-hw.claudio@gmail.com> In-Reply-To: <1426501911-1402-1-git-send-email-hw.claudio@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VHITg07bMtRDWoNngbvsWjRt1cokTsDo0" Subject: Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: hw.claudio@gmail.com, Luiz Capitulino Cc: Peter Maydell , Gonglei , Claudio Fontana , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VHITg07bMtRDWoNngbvsWjRt1cokTsDo0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/16/2015 04:31 AM, hw.claudio@gmail.com wrote: > From: Claudio Fontana >=20 > usage is similar to the commands x, xp. >=20 > Example with string: looking for "ELF" header in memory: >=20 > (qemu) s/1000000cb 0x40001000 "ELF" > searching memory area [0000000040001000-00000000400f5240] > 0000000040090001 > (qemu) x/20b 0x40090000 > 0000000040090000: '\x7f' 'E' 'L' 'F' '\x02' '\x01' '\x01' '\x03' > 0000000040090008: '\x00' '\x00' '\x00' '\x00' '\x00' '\x00' '\x00' '\x0= 0' > 0000000040090010: '\x02' '\x00' '\xb7' '\x00' >=20 > Example with value: looking for 64bit variable value 0x990088 >=20 > (qemu) s/1000000xg 0xffff900042000000 0x990088 > searching memory area [ffff900042000000-ffff9000427a1200] > ffff9000424b3000 > ffff9000424c1000 >=20 > Signed-off-by: Claudio Fontana > --- > hmp-commands.hx | 28 ++++++++++++ > monitor.c | 140 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 168 insertions(+) >=20 > Hello, looking for some comments on whether the addition of this > command is welcome, and whether the syntax chosen is acceptable, > or how it can made better. Do you want to provide a QMP counterpart? In general, we are reluctant to add new HMP functionality that cannot also be accessed via QMP. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --VHITg07bMtRDWoNngbvsWjRt1cokTsDo0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVBuyLAAoJEKeha0olJ0Nq8OEIAKSl491PWV4a+2sme/jSF0Em MjA/g+so+xl4JkOHP7htG/NxFx6PwK7vx9BvdI7/t5WXMvMWPLY7jWQucI1KFigj x+Ce7dqPjuuvmAt3z1crLeb039lGX2cnazgCng7wPXJEfzc5KCT+y0Vvr84NsP2y nx6W/Z+vEIOUEIbzjQxASiF4XQYSMFzGdPWDSt+CAe7q+pj+Pc+E/f9bAvzkA4PP ssJOIaoLoCHu2wpTHiYS8k3MwaD+uFjoCEK+ZwiNCbN1tTvGZeY5otZywuU2JQiN QHnh6MEV3kepgCdRn1ow/Fv5RxQ5PgihP9Mue0Bo/FFw893Ti5fJB9jvAHvnzos= =I1W8 -----END PGP SIGNATURE----- --VHITg07bMtRDWoNngbvsWjRt1cokTsDo0--