From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YXWzg-0001OS-AK
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:31:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YXWzZ-0001rn-7G
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:31:52 -0400
Received: from mail-qg0-x234.google.com ([2607:f8b0:400d:c04::234]:33121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1YXWzZ-0001r9-2T
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 11:31:45 -0400
Received: by qgfa8 with SMTP id a8so43172545qgf.0
	for <qemu-devel@nongnu.org>; Mon, 16 Mar 2015 08:31:44 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5506F75C.6060205@twiddle.net>
Date: Mon, 16 Mar 2015 08:31:40 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <BLU437-SMTP25F3E8ED2ECC012B08FFF5B9040@phx.gbl>
In-Reply-To: <BLU437-SMTP25F3E8ED2ECC012B08FFF5B9040@phx.gbl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] Execute _start and reach to the first
 function call successfully
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <xili_gchen_5257@hotmail.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmU=?= =?UTF-8?B?cg==?= <afaerber@suse.de>, Chris Metcalf <cmetcalf@ezchip.com>, Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, "walt@tilera.com" <walt@tilera.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 03/13/2015 11:03 PM, Chen Gang wrote:
> +static void decode_rrr_1_opcode_y0(struct DisasContext *dc,
> +                                   tilegx_bundle_bits bundle)
> +{
> +    switch (get_RRROpcodeExtension_Y0(bundle)) {
> +    case UNARY_RRR_1_OPCODE_Y0:
> +        switch (get_UnaryOpcodeExtension_Y0(bundle)) {
> +        case  FNOP_UNARY_OPCODE_Y0:
> +            if (!get_SrcA_Y0(bundle) && !get_Dest_Y0(bundle)) {
> +                gen_fnop();
> +                return;
> +            }
> +            break;
> +        default:
> +            break;
> +        }
> +        break;
> +    default:
> +        break;
> +    }
> +
> +    qemu_log_mask(LOG_UNIMP, "UNIMP rrr_1_opcode_y0, %16.16llx\n", bundle);
> +    dc->exception = TILEGX_EXCP_OPCODE_UNIMPLEMENT;
> +}

I think it would be helpful if, in the first patch, you put all of the opcode
symbols into the proper place in the switch statements.  That way it's easy to
tell at a glance what has yet to be implemented.  For instance, for this
function you'd put

$ grep _UNARY opcode_tilegx.h  | grep _Y0
  CNTLZ_UNARY_OPCODE_Y0 = 1,
  CNTTZ_UNARY_OPCODE_Y0 = 2,
  FNOP_UNARY_OPCODE_Y0 = 3,
  FSINGLE_PACK1_UNARY_OPCODE_Y0 = 4,
  NOP_UNARY_OPCODE_Y0 = 5,
  PCNT_UNARY_OPCODE_Y0 = 6,
  REVBITS_UNARY_OPCODE_Y0 = 7,
  REVBYTES_UNARY_OPCODE_Y0 = 8,
  TBLIDXB0_UNARY_OPCODE_Y0 = 9,
  TBLIDXB1_UNARY_OPCODE_Y0 = 10,
  TBLIDXB2_UNARY_OPCODE_Y0 = 11,
  TBLIDXB3_UNARY_OPCODE_Y0 = 12,

in the get_UnaryOpcodeExtension_Y0 switch statement and

$ grep _RRR_1 opcode_tilegx.h  | grep _Y0
  SHL1ADD_RRR_1_OPCODE_Y0 = 0,
  SHL2ADD_RRR_1_OPCODE_Y0 = 1,
  SHL3ADD_RRR_1_OPCODE_Y0 = 2,
  UNARY_RRR_1_OPCODE_Y0 = 3,

in the get_RRROpcodeExtension_Y0 switch statement.

Likewise with all of the other "decode" functions that contain a switch.

> +    qemu_log("fnop\n");
> +    qemu_log("addi r%d, r%d, %d\n", rdst, rsrc, imm8);

Again, use qemu_log_mask(CPU_LOG_TB_IN_ASM).



r~