From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXXlG-0006Lw-JD for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:21:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXXl9-0005eT-5z for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:21:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXXl8-0005eM-Uz for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:20:55 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2GGKsXL012662 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Mar 2015 12:20:54 -0400 Message-ID: <550702E5.20801@redhat.com> Date: Mon, 16 Mar 2015 12:20:53 -0400 From: Max Reitz MIME-Version: 1.0 References: <1426240033-24673-1-git-send-email-kraxel@redhat.com> <1426240033-24673-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1426240033-24673-3-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/9] virtio-gpu/2d: add hardware spec include file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Dave Airlie On 2015-03-13 at 05:47, Gerd Hoffmann wrote: > This patch adds the header file with structs and defines for > the virtio based gpu device. Covers 2d operations only. > > Written by Dave Airlie and Gerd Hoffmann. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann > --- > include/hw/virtio/virtgpu_hw.h | 203 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 203 insertions(+) > create mode 100644 include/hw/virtio/virtgpu_hw.h There are some conflicts with the latest specification I was able to obtain (https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-gpu.pdf); for instance, the ordering of the fields in virtio_gpu_resp_display_info is different there, some GPU formats are different (but no conflict), and so on. However, I guess this file will be pretty much the specification for the interface, so as long as it makes sense and it compiles, it's correct. Reviewed-by: Max Reitz