From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52822)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jwhite@codeweavers.com>) id 1YXYGM-0008NF-0G
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:53:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jwhite@codeweavers.com>) id 1YXYGG-0000Eh-NW
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:53:09 -0400
Received: from mail.codeweavers.com ([216.251.189.131]:33956)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jwhite@codeweavers.com>) id 1YXYGG-0000Ah-HA
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 12:53:04 -0400
Message-ID: <55070A69.5010908@codeweavers.com>
Date: Mon, 16 Mar 2015 11:52:57 -0500
From: Jeremy White <jwhite@codeweavers.com>
MIME-Version: 1.0
References: <1426275924-1904-1-git-send-email-jwhite@codeweavers.com>
	<CAJ+F1CLvNMy1H-yi9fvjPQEMRF9Gv1DZcbUo7fjaVcqo=zEouQ@mail.gmail.com>
In-Reply-To: <CAJ+F1CLvNMy1H-yi9fvjPQEMRF9Gv1DZcbUo7fjaVcqo=zEouQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to
 libcacard
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>

Hey Marc-André,

Thanks for the review.

On 03/16/2015 11:22 AM, Marc-André Lureau wrote:
> Hi Jeremy
> 
> I have checked no regression for spice, but not the new pcsc backend.
> Do you have a spice-gtk branch or are you using vscclient only?

I'm using spice-gtk with this patch:
  http://lists.freedesktop.org/archives/spice-devel/2015-January/018674.html
and then invoking it with --spice-smartcard[=passthru]

> 
> I would feel better note polluting more the exported symbols from
> libcacard. For ex, vcard_init() and cac_card_init() are already quite
> useless, since they are called from vcard_emul_init() Would you be
> able to init PCSC there too, when it's selected? (there are too many
> init or exported functions already)
> 
> Why did you export vcard_response_set_status_bytes()?
> 

It seemed as though the convention was that all non static functions
went into the .syms file; I may have misunderstood.

capcsc_init certainly does not need to be exported; it is only intended
to be used from vcard_emul_init().  I thought I was simply following
existing convention.

For vcard_response_set_status_bytes, I needed that function in capcsc.c.
 Again, I followed what I saw as the convention.  However, that one is
perhaps arguably more useful to export; certainly if you're going to
export the other vcard_response_xxx functions, this would be a useful
one to add to the mix.

Cheers,

Jeremy