From: Paolo Bonzini <pbonzini@redhat.com>
To: "Jeremy White" <jwhite@codeweavers.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard
Date: Mon, 16 Mar 2015 18:19:39 +0100 [thread overview]
Message-ID: <550710AB.6040105@redhat.com> (raw)
In-Reply-To: <55070A69.5010908@codeweavers.com>
On 16/03/2015 17:52, Jeremy White wrote:
> It seemed as though the convention was that all non static functions
> went into the .syms file; I may have misunderstood.
I suspect that the .syms file was introduced as a way to hide utility
functions from libqemuutil.a. Now that libqemuutil is not used anymore
in libcacard, we should either remove the .syms file or shave its
contents. This is of course not falling on you.
Paolo
> capcsc_init certainly does not need to be exported; it is only intended
> to be used from vcard_emul_init(). I thought I was simply following
> existing convention.
next prev parent reply other threads:[~2015-03-16 17:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 19:45 [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard Jeremy White
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 1/7] Bug fix: delete the reader entry after queueing an event, not before Jeremy White
2015-03-25 15:12 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 2/7] Retrieve the correct TD byte when checking an ATR Jeremy White
2015-03-25 15:12 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 3/7] Add a configure check for libpcsclite, and an option to enable or disable it Jeremy White
2015-03-25 15:13 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 4/7] Add error checking to vcard_emul_options Jeremy White
2015-03-25 15:13 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 5/7] Add a VCARD_DIRECT implemention to the libcacard smartcard support Jeremy White
2015-03-25 15:13 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 6/7] Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard Jeremy White
2015-03-25 15:14 ` Marc-André Lureau
2015-03-13 19:45 ` [Qemu-devel] [PATCH v3 7/7] Remove the (broken) passthru option Jeremy White
2015-03-25 15:14 ` Marc-André Lureau
2015-03-13 20:11 ` [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard Patchew Tool
2015-03-16 16:22 ` Marc-André Lureau
2015-03-16 16:52 ` Jeremy White
2015-03-16 17:19 ` Paolo Bonzini [this message]
2015-03-25 15:15 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550710AB.6040105@redhat.com \
--to=pbonzini@redhat.com \
--cc=jwhite@codeweavers.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).