From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXYg7-00038b-RR for qemu-devel@nongnu.org; Mon, 16 Mar 2015 13:19:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXYg2-0008Ul-Oq for qemu-devel@nongnu.org; Mon, 16 Mar 2015 13:19:47 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:33161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXYg2-0008Uh-H1 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 13:19:42 -0400 Received: by wixw10 with SMTP id w10so33729657wix.0 for ; Mon, 16 Mar 2015 10:19:42 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <550710AB.6040105@redhat.com> Date: Mon, 16 Mar 2015 18:19:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426275924-1904-1-git-send-email-jwhite@codeweavers.com> <55070A69.5010908@codeweavers.com> In-Reply-To: <55070A69.5010908@codeweavers.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/7] Add support for passthru cards to libcacard List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeremy White , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVy?= =?UTF-8?B?ZWF1?= Cc: QEMU On 16/03/2015 17:52, Jeremy White wrote: > It seemed as though the convention was that all non static functions > went into the .syms file; I may have misunderstood. I suspect that the .syms file was introduced as a way to hide utility functions from libqemuutil.a. Now that libqemuutil is not used anymore in libcacard, we should either remove the .syms file or shave its contents. This is of course not falling on you. Paolo > capcsc_init certainly does not need to be exported; it is only intended > to be used from vcard_emul_init(). I thought I was simply following > existing convention.