From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXaW0-0000a3-7D for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:17:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXaVn-0003wE-F7 for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:17:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXaVn-0003vr-6o for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:17:15 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2GJHE1K011123 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Mar 2015 15:17:14 -0400 Message-ID: <55072C39.4000408@redhat.com> Date: Mon, 16 Mar 2015 15:17:13 -0400 From: Max Reitz MIME-Version: 1.0 References: <1426240033-24673-1-git-send-email-kraxel@redhat.com> <1426240033-24673-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1426240033-24673-6-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/9] virtio-vga: add virtio gpu device with vga compatibility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Dave Airlie , "Michael S. Tsirkin" On 2015-03-13 at 05:47, Gerd Hoffmann wrote: > This patch adds a virtio-vga device. It is simliar to virtio-gpu-pci, > but it also adds in vga compatibility, so guests without native > virtio-gpu support can drive the device in vga mode. > > Written by Dave Airlie and Gerd Hoffmann. > > Signed-off-by: Dave Airlie > Signed-off-by: Gerd Hoffmann > --- > default-configs/x86_64-softmmu.mak | 1 + > hw/display/Makefile.objs | 1 + > hw/display/virtio-vga.c | 150 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 152 insertions(+) > create mode 100644 hw/display/virtio-vga.c Looks good to me, but I can't really give an R-b because I'm really unfamiliar with all things concerning VGA. Max