From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39428)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YXajC-0007m9-96
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:31:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YXaj7-0000ck-AG
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:31:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58503)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YXaj7-0000cF-3F
	for qemu-devel@nongnu.org; Mon, 16 Mar 2015 15:31:01 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2GJV0JX024595
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 16 Mar 2015 15:31:00 -0400
Message-ID: <55072F73.2080104@redhat.com>
Date: Mon, 16 Mar 2015 15:30:59 -0400
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1426240033-24673-1-git-send-email-kraxel@redhat.com>
	<1426240033-24673-7-git-send-email-kraxel@redhat.com>
In-Reply-To: <1426240033-24673-7-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/9] virtio-vga: add '-vga virtio' support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Dave Airlie <airlied@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 2015-03-13 at 05:47, Gerd Hoffmann wrote:
> Some convinience fluff:  Add support for '-vga virtio', also add
> virtio-vga to the list of vga cards so '-device virtio-vga' will
> turn off the default vga.
>
> Written by Dave Airlie and Gerd Hoffmann.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   hw/pci/pci.c            |  2 ++
>   include/sysemu/sysemu.h |  2 +-
>   qemu-options.hx         |  4 +++-
>   vl.c                    | 13 +++++++++++++
>   4 files changed, 19 insertions(+), 2 deletions(-)

Hm, the other VGA devices which support only PCI ("vmware" and "qxl") 
emit explicit error messages in isa_vga_init(). Maybe we should do the 
same? Without, the initialization fails silently and qemu starts, but 
there is no display ("-machine isapc -display virtio").

Max