Re: [Qemu-devel] [PATCH] spapr: Add missing checks for NULL pointers and report failures

[Alexander Graf <agraf@suse.de>]

On 14.03.15 11:29, Stefan Weil wrote:
> This fixes potential runtime crashes and two warnings from Coverity.
> 
> The new error message does not add  a prefix "qemu:" because that is
> already done in function hw_error. It also starts with an uppercase
> letter because that seems to be the mostly used form.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

I've squashed the patch below into your commit as well.


Alex

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 9c87a70..7febff7 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1507,7 +1507,7 @@ static void ppc_spapr_init(MachineState *machine)

     filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin");
     if (!filename) {
-        hw_error("Could not find LPAR rtas '%s'\n", spapr-rtas.bin);
+        hw_error("Could not find LPAR rtas '%s'\n", "spapr-rtas.bin");
         exit(1);
     }
     spapr->rtas_size = get_image_size(filename);