From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXqKn-00038h-Q4 for qemu-devel@nongnu.org; Tue, 17 Mar 2015 08:11:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXqKg-0000ls-Rj for qemu-devel@nongnu.org; Tue, 17 Mar 2015 08:10:57 -0400 Message-ID: <550819B2.4080908@huawei.com> Date: Tue, 17 Mar 2015 20:10:26 +0800 From: Gonglei MIME-Version: 1.0 References: <1426591711-14472-1-git-send-email-arei.gonglei@huawei.com> <1426593537.27188.95.camel@nilsson.home.kraxel.org> In-Reply-To: <1426593537.27188.95.camel@nilsson.home.kraxel.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: fix segfault when hot-unplugging usb host adapter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-stable , qemu-devel@nongnu.org, peter.huangpeng@huawei.com On 2015/3/17 19:58, Gerd Hoffmann wrote: >> + qemu_unregister_reset(ehci_reset, s); > > We should hook up reset via DeviceClass->reset then (xhci already does > it this way) and drop the qemu_register_reset() calls. > > Then qemu will register and unregister the reset handler automatically > for us. > I'll look for this, thanks :) Regards, -Gonglei