From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXsOC-0006sh-JJ for qemu-devel@nongnu.org; Tue, 17 Mar 2015 10:22:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXsO7-0004fD-1Z for qemu-devel@nongnu.org; Tue, 17 Mar 2015 10:22:36 -0400 Message-ID: <550838A0.8060609@redhat.com> Date: Tue, 17 Mar 2015 08:22:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426596537-22616-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1426596537-22616-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nNMwFvmg8212AqkIhRL4rkL4BOrJpvqND" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH for-2.3] raw-posix: Deprecate aio=threads fallback without O_DIRECT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: famz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nNMwFvmg8212AqkIhRL4rkL4BOrJpvqND Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2015 06:48 AM, Kevin Wolf wrote: > Currently, if the user requests aio=3Dnative, but forgets to choose a > cache mode that sets O_DIRECT, that request is silently ignored and raw= > falls back to aio=3Dthreads. >=20 > Deprecate that behaviour so we can make it an error in future qemu > versions. >=20 > Signed-off-by: Kevin Wolf > --- > block/raw-posix.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Silent behavior changes are always mean, so making this noisy for now with the intent of an error in the future is good. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nNMwFvmg8212AqkIhRL4rkL4BOrJpvqND Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCDigAAoJEKeha0olJ0NqleAIAKKQVpPLFVgrI/Om6o3U26Qy Qo7xbFP5xmq96L1CgMeoDOcpDDVFwz26Tm2bSS53/dtc4Iy+M99nx8J7tqpBIW0V SkwXNJJ/hpkk4GFEf3YrVU6kUwGDBruPQf70UkS/P7g2q2ehikDCrA3dxi+072ft GjAMmt7B9ilBemgKq6Q4jQmoPpDPz/Xq8HGYlAInsNa0SNpwiueAxNLBFHRe+cxh T2CHaZs60M3jV4/SPXJgJUIZaGa4hiyQmvFy13QM2yjq5wawuG6HBT9bEqF0e2mm ezc6Eh6JVzpUdQRI8xWzN2QiSu15KU73HgcVqLdgtca1pmyn0seokfpUOElwgFU= =rmB0 -----END PGP SIGNATURE----- --nNMwFvmg8212AqkIhRL4rkL4BOrJpvqND--