From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41867)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YXswu-0001TD-Vt
	for qemu-devel@nongnu.org; Tue, 17 Mar 2015 10:58:33 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YXswq-00089Y-KP
	for qemu-devel@nongnu.org; Tue, 17 Mar 2015 10:58:28 -0400
Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:35211)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YXswq-00089R-ED
	for qemu-devel@nongnu.org; Tue, 17 Mar 2015 10:58:24 -0400
Received: by webcq43 with SMTP id cq43so9768628web.2
	for <qemu-devel@nongnu.org>; Tue, 17 Mar 2015 07:58:23 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5508410B.8030003@redhat.com>
Date: Tue, 17 Mar 2015 15:58:19 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1426593410-21405-1-git-send-email-stefanha@redhat.com>
	<1426593410-21405-6-git-send-email-stefanha@redhat.com>
In-Reply-To: <1426593410-21405-6-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/7] omap_intc: convert ffs(3) to ctz32()
	in omap_inth_sir_update()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>



On 17/03/2015 12:56, Stefan Hajnoczi wrote:
> +        for (f = ctz32(level) + 1, i = f - 1, level >>= f - 1;
> +             f != 33;
> +             i += f, level >>= f) {
>              p = s->bank[j].priority[i];
>              if (p <= p_intr) {
>                  p_intr = p;
>                  sir_intr = 32 * j + i;
>              }
> -            f = ffs(level >> 1);
> +            f = ctz32(level >> 1) + 1;
>          }

Since it's 2.4, we might as well make the code nicer:

         while (level != 0) {
             i = ctz32(level);
             p = s->bank[j].priority[i];
             if (p <= p_intr) {
                 p_intr = p;
                 sir_intr = 32 * j + i;
             }
             level &= level - 1;
         }

Paolo