From: Eric Blake <eblake@redhat.com>
To: Viswesh <visweshn92@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, kbastian@mail.uni-paderborn.de,
aneesh.kumar@linux.vnet.ibm.com, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] Fix typos in comments
Date: Tue, 17 Mar 2015 09:24:57 -0600 [thread overview]
Message-ID: <55084749.4030607@redhat.com> (raw)
In-Reply-To: <1426603988-3541-1-git-send-email-visweshn92@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On 03/17/2015 08:53 AM, Viswesh wrote:
> The commit message is changed per review comments of Peter Maydell.
> This should be good now.
These two sentences...
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Viswesh <visweshn92@gmail.com>
> ---
...belong better here. They describe how the patch changed from v1, and
not the patch itself (that is, a year from now when reading 'git log',
we won't care how many revisions it took to get to the patch that was
accepted, we will only care about the one revision that was accepted).
> fsdev/virtfs-proxy-helper.c | 2 +-
> target-tricore/translate.c | 22 +++++++++++-----------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-17 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 14:53 [Qemu-devel] [PATCH v2] Fix typos in comments Viswesh
2015-03-17 15:24 ` Eric Blake [this message]
2015-03-19 8:32 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55084749.4030607@redhat.com \
--to=eblake@redhat.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=visweshn92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).