From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXtNB-0003JA-Jb for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:25:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXtN7-0001lo-9J for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:25:37 -0400 Message-ID: <55084749.4030607@redhat.com> Date: Tue, 17 Mar 2015 09:24:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426603988-3541-1-git-send-email-visweshn92@gmail.com> In-Reply-To: <1426603988-3541-1-git-send-email-visweshn92@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JUskqUqpu8k02nebT4mmQgK2ePUu026Wt" Subject: Re: [Qemu-devel] [PATCH v2] Fix typos in comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Viswesh , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, kbastian@mail.uni-paderborn.de, aneesh.kumar@linux.vnet.ibm.com, peter.maydell@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JUskqUqpu8k02nebT4mmQgK2ePUu026Wt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/17/2015 08:53 AM, Viswesh wrote: > The commit message is changed per review comments of Peter Maydell. > This should be good now. These two sentences... >=20 > Reviewed-by: Peter Maydell > Signed-off-by: Viswesh > --- =2E..belong better here. They describe how the patch changed from v1, an= d not the patch itself (that is, a year from now when reading 'git log', we won't care how many revisions it took to get to the patch that was accepted, we will only care about the one revision that was accepted). > fsdev/virtfs-proxy-helper.c | 2 +- > target-tricore/translate.c | 22 +++++++++++----------- > 2 files changed, 12 insertions(+), 12 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JUskqUqpu8k02nebT4mmQgK2ePUu026Wt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCEdJAAoJEKeha0olJ0Nq4hIH/2o6CrRZl8MGuf1AFJQSXek+ dbF4kb/aYpWgNetfC5vDmBicdeIMvHwJqWYdlBuVJk/Sisjm75Cu4U1HpjUDDT8S jXW6zItRxfv/TEXO8IjxQFNTuR371iLsjPTKyuvLrIGSVW1cFb7PULquYTsIuyQv H0rsSs5qsTiDkYKxXQr3dD/MQjcHdyBf91KfER81KW5Mx4yIi1g7Htyt1deEwvq7 H1TwZ/Imzo+2zilCdKAnXrrl5mKvMum0KYrnr7AtVQoD1esJJdhHebDzrLF36Kpe yF4bCHwse8WA08Tu8BOWSTI2vnn4WhrXRnG2CdOxHV7Hn4Klx4jgdlR4Wa5JjzQ= =F9LK -----END PGP SIGNATURE----- --JUskqUqpu8k02nebT4mmQgK2ePUu026Wt--