From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXxBZ-0005hj-VO for qemu-devel@nongnu.org; Tue, 17 Mar 2015 15:29:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXxBU-00017Z-K1 for qemu-devel@nongnu.org; Tue, 17 Mar 2015 15:29:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXxBU-000168-BS for qemu-devel@nongnu.org; Tue, 17 Mar 2015 15:29:48 -0400 Message-ID: <550880A2.4020103@redhat.com> Date: Tue, 17 Mar 2015 20:29:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426478258-29961-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1426478258-29961-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu] profiler: Reenable built-in profiler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Peter Maydell , Alexander Graf On 16/03/2015 04:57, Alexey Kardashevskiy wrote: > 2ed1ebcf6 "timer: replace time() with QEMU_CLOCK_HOST" broke compile > when configured with --enable-profiler. Turned out the profiler has been > broken for a while. > > This does s/qemu_time/tcg_time/ as the profiler only works in a TCG mode. > This also fixes the compile error. > > This changes profile_getclock() to return nanoseconds rather than > CPU ticks as the "profile" HMP command prints seconds and there is no > platform-independent way to get ticks-per-second rate. > Since TCG is quite slow and get_clock() returns nanoseconds (fine > enough), this should not affect precision much. > > This removes unused qemu_time_start and tlb_flush_time. > > Signed-off-by: Alexey Kardashevskiy Thanks, applied. Paolo