From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYEsx-0007tS-9E for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYEst-0000Es-JP for qemu-devel@nongnu.org; Wed, 18 Mar 2015 10:23:51 -0400 Message-ID: <55098A68.2090907@redhat.com> Date: Wed, 18 Mar 2015 10:23:36 -0400 From: John Snow MIME-Version: 1.0 References: <1426625899-25348-1-git-send-email-jsnow@redhat.com> <871tkmkcej.fsf@blackfin.pond.sub.org> In-Reply-To: <871tkmkcej.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org On 03/18/2015 03:11 AM, Markus Armbruster wrote: > John Snow writes: > >> A thinko that clang 3.5.0 caught. >> Thankfully does not introduce any new failures. >> >> Signed-off-by: John Snow > > How you caught the bug is interesting enough to be mentioned in the > commit message, but the nature of the bug surely is more interesting > than that. Suggest to change the subject to > > qtest/ahci: Fix a bit mask expression > > Perhaps it can be fixed up on commit. > > Reviewed-by: Markus Armbruster > If it goes in through trivial, can we change this to Markus's suggestion? Thank you, --js