From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYMsE-0008B3-Tm for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYMsB-0000LE-Jt for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:55:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYMsB-0000L1-Ed for qemu-devel@nongnu.org; Wed, 18 Mar 2015 18:55:35 -0400 Message-ID: <550A0265.80806@redhat.com> Date: Wed, 18 Mar 2015 18:55:33 -0400 From: John Snow MIME-Version: 1.0 References: <1426718625-24120-1-git-send-email-jsnow@redhat.com> <1426718625-24120-2-git-send-email-jsnow@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Bastian Koppelmann , QEMU Developers , Stefan Hajnoczi On 03/18/2015 06:51 PM, Peter Maydell wrote: > On 18 March 2015 at 22:43, John Snow wrote: >> Calling abs() on a uint32_t is a no-op, so remove it. >> clang 3.5.0 will not compile this if -Werror is set, >> throwing a -Wabsolute-value warning. >> >> Signed-off-by: John Snow > > This is probably the wrong fix (ie it silences the > warning rather than fixing the bug). See > http://patchwork.ozlabs.org/patch/447585/ > > thanks > -- PMM > Ah, I missed that there was another patch out there and a deeper bug. I thought this was a harmless abs() inclusion, but I didn't look too deeply at it. I am fine with dropping this patch if a more comprehensive change is in the works, but the other three should still stand. --js