From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYbL7-0001T4-06 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:22:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYbL1-0005xk-FI for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:22:24 -0400 Message-ID: <550ADB8E.3060908@redhat.com> Date: Thu, 19 Mar 2015 08:22:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426577774-21605-1-git-send-email-armbru@redhat.com> <20150319112954.GB3845@noname.redhat.com> In-Reply-To: <20150319112954.GB3845@noname.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rc2XPO3JXt2hmPP6lNueHImWQSoXUe7k8" Subject: Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Markus Armbruster Cc: famz@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rc2XPO3JXt2hmPP6lNueHImWQSoXUe7k8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/19/2015 05:29 AM, Kevin Wolf wrote: > Am 17.03.2015 um 08:36 hat Markus Armbruster geschrieben: >> Error classes are a leftover from the days of "rich" error objects. >> New code should always use ERROR_CLASS_GENERIC_ERROR. Commit >> b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace >> them. >> >> Signed-off-by: Markus Armbruster >=20 > Thanks, applied to the block branch. >=20 > Eric, please speak up if libvirt needs the error code for any of these.= Libvirt is not using blockdev-backup yet, and so by implication does not care about the error class. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --rc2XPO3JXt2hmPP6lNueHImWQSoXUe7k8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCtuOAAoJEKeha0olJ0NqAcIIAJgrJyM36EPP/gidssp8DRn4 MvnDBUFhn+mgX7isIkdNN/+EpUBhY3VA7Fb5hXv1imQd0j9QWvfIfGNmSlw446HU ibhyUH+iLcjZxXPrFVk+N/A9BayBfdDuXTD/okm29Yxaf+ju9JuNTfczW+vJ3wSd HgCQBFBwbJ5yig3n8QEKNg634BsRngP40C4hVtxPTjjQMdZZ+vJ5CwKSKEc3xWNf WeSuAMd4gi9RkorHdMfJAPY1Gd0+0b5v5Ub8RJ1CyOAWQDgUxrt2ndZh4kINfKiS 3X2CQmOsLDeLalBhhgIj+0SiWscv3sXgABY/bXDlfzMJYl7xgtLWEYkFSDNkzQY= =eDPm -----END PGP SIGNATURE----- --rc2XPO3JXt2hmPP6lNueHImWQSoXUe7k8--