From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41937)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YYbe5-0004cn-Gd
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:42:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YYbe2-000419-8m
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:42:01 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YYbe2-000415-12
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:41:58 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2JEfvCf026428
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 19 Mar 2015 10:41:57 -0400
Message-ID: <550AE034.1070700@redhat.com>
Date: Thu, 19 Mar 2015 10:41:56 -0400
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1424272761-27554-1-git-send-email-kwolf@redhat.com>
	<1424272761-27554-3-git-send-email-kwolf@redhat.com>
In-Reply-To: <1424272761-27554-3-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Some qemu-img convert
	tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com

On 2015-02-18 at 10:19, Kevin Wolf wrote:
> This adds a regression test for some problems that the qemu-img convert
> rewrite just fixed.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>   tests/qemu-iotests/122     | 83 ++++++++++++++++++++++++++++++++++++++++++++++
>   tests/qemu-iotests/122.out | 30 +++++++++++++++++
>   tests/qemu-iotests/group   |  1 +
>   3 files changed, 114 insertions(+)
>   create mode 100755 tests/qemu-iotests/122
>   create mode 100644 tests/qemu-iotests/122.out

[snip]

> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 4b2b93b..28c78e5 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -117,3 +117,4 @@
>   113 rw auto quick
>   114 rw auto quick
>   116 rw auto quick
> +122 rw auto quick

This test takes 17 s on my HDD, and 7 s in tmpfs. Are you sure it should 
be added to the "quick" group?

Other than that, looks good.

Max