From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert tests
Date: Thu, 19 Mar 2015 10:44:07 -0400 [thread overview]
Message-ID: <550AE0B7.80800@redhat.com> (raw)
In-Reply-To: <1426768413-31079-4-git-send-email-kwolf@redhat.com>
On 2015-03-19 at 08:33, Kevin Wolf wrote:
> This adds a regression test for some problems that the qemu-img convert
> rewrite just fixed.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/122 | 223 +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/122.out | 209 ++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 433 insertions(+)
> create mode 100755 tests/qemu-iotests/122
> create mode 100644 tests/qemu-iotests/122.out
[snip]
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index 6262127..7c20ace 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -122,5 +122,6 @@
> 115 rw auto
> 116 rw auto quick
> 121 rw auto
> +122 rw auto quick
> 123 rw auto quick
> 128 rw auto quick
As I mistakenly replied to v2 just now, this test takes 17 s on my HDD,
and 7 s in tmpfs. So are you sure it should be added to the "quick" group?
The test itself looks good, though.
Max
next prev parent reply other threads:[~2015-03-19 14:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 12:33 [Qemu-devel] [PATCH v2 0/3] qemu-img convert: Rewrite copying logic Kevin Wolf
2015-03-19 12:33 ` [Qemu-devel] [PATCH v2 1/3] block-backend: Expose bdrv_write_zeroes() Kevin Wolf
2015-03-19 13:27 ` Max Reitz
2015-03-19 12:33 ` [Qemu-devel] [PATCH v2 2/3] qemu-img convert: Rewrite copying logic Kevin Wolf
2015-03-19 13:53 ` Max Reitz
2015-03-19 12:33 ` [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert tests Kevin Wolf
2015-03-19 14:44 ` Max Reitz [this message]
2015-03-19 14:44 ` Max Reitz
2015-04-02 9:53 ` [Qemu-devel] [PATCH v2 0/3] qemu-img convert: Rewrite copying logic Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AE0B7.80800@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).