From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YYbgy-0007Yi-F8
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:45:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YYbgx-0004b8-Ih
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 10:45:00 -0400
Message-ID: <550AE0E2.6010802@redhat.com>
Date: Thu, 19 Mar 2015 10:44:50 -0400
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1426768413-31079-1-git-send-email-kwolf@redhat.com>
	<1426768413-31079-4-git-send-email-kwolf@redhat.com>
	<550AE0B7.80800@redhat.com>
In-Reply-To: <550AE0B7.80800@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Some qemu-img convert
	tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com

On 2015-03-19 at 10:44, Max Reitz wrote:
> On 2015-03-19 at 08:33, Kevin Wolf wrote:
>> This adds a regression test for some problems that the qemu-img convert
>> rewrite just fixed.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>   tests/qemu-iotests/122     | 223 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/122.out | 209 
>> ++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/group   |   1 +
>>   3 files changed, 433 insertions(+)
>>   create mode 100755 tests/qemu-iotests/122
>>   create mode 100644 tests/qemu-iotests/122.out
>
> [snip]
>
>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
>> index 6262127..7c20ace 100644
>> --- a/tests/qemu-iotests/group
>> +++ b/tests/qemu-iotests/group
>> @@ -122,5 +122,6 @@
>>   115 rw auto
>>   116 rw auto quick
>>   121 rw auto
>> +122 rw auto quick
>>   123 rw auto quick
>>   128 rw auto quick
>
> As I mistakenly replied to v2 just now, this test takes 17 s on my 
> HDD, and 7 s in tmpfs. So are you sure it should be added to the 
> "quick" group?

*v1... I somehow don't seem too awake today.

> The test itself looks good, though.
>
> Max