From: Laszlo Ersek <lersek@redhat.com>
To: "Gabriel L. Somlo" <somlo@cmu.edu>
Cc: matt.fleming@intel.com, mdroth@linux.vnet.ibm.com,
rjones@redhat.com, jordan.l.justen@intel.com,
qemu-devel@nongnu.org, gleb@cloudius-systems.com,
gsomlo@gmail.com, kraxel@redhat.com, pbonzini@redhat.com,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/5] fw_cfg: prevent selector key conflict
Date: Thu, 19 Mar 2015 17:18:48 +0100 [thread overview]
Message-ID: <550AF6E8.30806@redhat.com> (raw)
In-Reply-To: <1426724311-9343-4-git-send-email-somlo@cmu.edu>
On 03/19/15 01:18, Gabriel L. Somlo wrote:
> Enforce a single assignment of data for each distinct selector key.
>
> Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
> ---
> hw/nvram/fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 2f609b4..659de4c 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -423,6 +423,7 @@ static void fw_cfg_add_bytes_read_callback(FWCfgState *s, uint16_t key,
> key &= FW_CFG_ENTRY_MASK;
>
> assert(key < FW_CFG_MAX_ENTRY && len < UINT32_MAX);
> + assert(s->entries[arch][key].data == NULL); /* avoid key conflict */
>
> s->entries[arch][key].data = data;
> s->entries[arch][key].len = (uint32_t)len;
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2015-03-19 16:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 0:18 [Qemu-devel] [PATCH v2 0/5] fw-cfg: documentation, cleanup, and cmdline blobs Gabriel L. Somlo
2015-03-19 0:18 ` [Qemu-devel] [PATCH v2 1/5] fw_cfg: add documentation file (docs/specs/fw_cfg.txt) Gabriel L. Somlo
2015-03-19 16:14 ` Laszlo Ersek
2015-03-19 0:18 ` [Qemu-devel] [PATCH v2 2/5] fw_cfg: remove support for guest-side data writes Gabriel L. Somlo
2015-03-19 16:16 ` Laszlo Ersek
2015-03-19 0:18 ` [Qemu-devel] [PATCH v2 3/5] fw_cfg: prevent selector key conflict Gabriel L. Somlo
2015-03-19 16:18 ` Laszlo Ersek [this message]
2015-03-19 0:18 ` [Qemu-devel] [PATCH v2 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names Gabriel L. Somlo
2015-03-19 16:34 ` Laszlo Ersek
2015-03-20 6:51 ` Laszlo Ersek
2015-03-20 14:34 ` Gabriel L. Somlo
2015-03-20 18:28 ` Laszlo Ersek
2015-03-19 0:18 ` [Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline Gabriel L. Somlo
2015-03-19 8:18 ` Markus Armbruster
2015-03-19 17:38 ` Laszlo Ersek
2015-03-20 18:01 ` Gabriel L. Somlo
2015-03-20 18:47 ` Gabriel L. Somlo
2015-03-23 7:33 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550AF6E8.30806@redhat.com \
--to=lersek@redhat.com \
--cc=armbru@redhat.com \
--cc=gleb@cloudius-systems.com \
--cc=gsomlo@gmail.com \
--cc=jordan.l.justen@intel.com \
--cc=kraxel@redhat.com \
--cc=matt.fleming@intel.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=somlo@cmu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).