From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYeCQ-0005St-Ch for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:25:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYeCK-00083n-4P for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:25:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYeCJ-00083S-P0 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:25:32 -0400 Message-ID: <550B067B.10609@redhat.com> Date: Thu, 19 Mar 2015 18:25:15 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150319171445.GO1832@HEDWIG.INI.CMU.EDU> In-Reply-To: <20150319171445.GO1832@HEDWIG.INI.CMU.EDU> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Setting FW_CFG_ID (was: [PATCH] fw_cfg: add documentation file) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , Laszlo Ersek Cc: matt.fleming@intel.com, mdroth@linux.vnet.ibm.com, rjones@redhat.com, jordan.l.justen@intel.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, gleb@cloudius-systems.com, kraxel@redhat.com, armbru@redhat.com On 19/03/2015 18:14, Gabriel L. Somlo wrote: > I'd be happy to add a patch factoring out the call to > > fw_cfg_add_i32(fw_cfg, FW_CFG_ID, 1); > > into fw_cfg_init1(), which would then make it consistent across all > architectures, including arm/virt. Yes, please---this should be a 2.3 blocker. Paolo