From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYee2-0003FF-Fk for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:54:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYedv-0000gH-S4 for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:54:10 -0400 Message-ID: <550B0D3A.7000903@suse.de> Date: Thu, 19 Mar 2015 18:54:02 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1426787272-17921-1-git-send-email-afaerber@suse.de> In-Reply-To: <1426787272-17921-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-stable Am 19.03.2015 um 18:47 schrieb Andreas F=C3=A4rber: > Use qtest_add_func() instead of g_test_add_func() to reflect > the architecture tested, changing GTester paths as follows: >=20 > /fw_cfg/foo -> /x86_64/fw_cfg/foo etc. >=20 Actually this should even be Cc: qemu-stable@nongnu.org It's been wrong since the beginning. Andreas > Signed-off-by: Andreas F=C3=A4rber > --- > tests/fw_cfg-test.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) >=20 > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index 5c8f8d6..9be78e9 100644 > --- a/tests/fw_cfg-test.c > +++ b/tests/fw_cfg-test.c > @@ -109,21 +109,21 @@ int main(int argc, char **argv) > =20 > fw_cfg =3D pc_fw_cfg_init(); > =20 > - g_test_add_func("/fw_cfg/signature", test_fw_cfg_signature); > - g_test_add_func("/fw_cfg/id", test_fw_cfg_id); > - g_test_add_func("/fw_cfg/uuid", test_fw_cfg_uuid); > - g_test_add_func("/fw_cfg/ram_size", test_fw_cfg_ram_size); > - g_test_add_func("/fw_cfg/nographic", test_fw_cfg_nographic); > - g_test_add_func("/fw_cfg/nb_cpus", test_fw_cfg_nb_cpus); > + qtest_add_func("fw_cfg/signature", test_fw_cfg_signature); > + qtest_add_func("fw_cfg/id", test_fw_cfg_id); > + qtest_add_func("fw_cfg/uuid", test_fw_cfg_uuid); > + qtest_add_func("fw_cfg/ram_size", test_fw_cfg_ram_size); > + qtest_add_func("fw_cfg/nographic", test_fw_cfg_nographic); > + qtest_add_func("fw_cfg/nb_cpus", test_fw_cfg_nb_cpus); > #if 0 > - g_test_add_func("/fw_cfg/machine_id", test_fw_cfg_machine_id); > - g_test_add_func("/fw_cfg/kernel", test_fw_cfg_kernel); > - g_test_add_func("/fw_cfg/initrd", test_fw_cfg_initrd); > - g_test_add_func("/fw_cfg/boot_device", test_fw_cfg_boot_device); > + qtest_add_func("fw_cfg/machine_id", test_fw_cfg_machine_id); > + qtest_add_func("fw_cfg/kernel", test_fw_cfg_kernel); > + qtest_add_func("fw_cfg/initrd", test_fw_cfg_initrd); > + qtest_add_func("fw_cfg/boot_device", test_fw_cfg_boot_device); > #endif > - g_test_add_func("/fw_cfg/max_cpus", test_fw_cfg_max_cpus); > - g_test_add_func("/fw_cfg/numa", test_fw_cfg_numa); > - g_test_add_func("/fw_cfg/boot_menu", test_fw_cfg_boot_menu); > + qtest_add_func("fw_cfg/max_cpus", test_fw_cfg_max_cpus); > + qtest_add_func("fw_cfg/numa", test_fw_cfg_numa); > + qtest_add_func("fw_cfg/boot_menu", test_fw_cfg_boot_menu); > =20 > cmdline =3D g_strdup_printf("-uuid 4600cb32-38ec-4b2f-8acb-81c6ea5= 4f2d8 "); > s =3D qtest_start(cmdline); --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)