From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYehp-0005C3-PQ for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:58:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYehj-0002Dh-Ti for qemu-devel@nongnu.org; Thu, 19 Mar 2015 13:58:05 -0400 Message-ID: <550B0E01.3020100@redhat.com> Date: Thu, 19 Mar 2015 13:57:21 -0400 From: John Snow MIME-Version: 1.0 References: <1426351846-6497-1-git-send-email-hpoussin@reactos.org> <55074FA1.3010204@redhat.com> <5507CD2B.9060007@reactos.org> <550ADC41.8030706@ilande.co.uk> In-Reply-To: <550ADC41.8030706@ilande.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fdc: remove sparc sun4m mutations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland , =?UTF-8?B?SGVydsOpIA==?= =?UTF-8?B?UG91c3NpbmVhdQ==?= , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 03/19/2015 10:25 AM, Mark Cave-Ayland wrote: > On 17/03/15 06:43, Herv=C3=A9 Poussineau wrote: > >> Hi, >> >> Le 16/03/2015 22:48, John Snow a =C3=A9crit : >>> On 03/14/2015 12:50 PM, Herv=C3=A9 Poussineau wrote: >>>> They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and >>>> 82407d1a4035e5bfefb53ffdcb270872f813b34c and lots of bug fixes were >>>> done after that. >>>> >>>> This fixes (at least) the detection of the floppy controller on >>>> Debian 4.0r9/SPARC, >>>> and SS-5's OBP initialization routine still works. >>>> >>> >>> Removing workaround code from six years ago in a device we hardly >>> touch seems sane to me if it doesn't appear to break the machine it >>> was originally architected for (SS-5, from 82407d1a's commit >>> message), but I am not well versed in SPARC configurations, >>> unfortunately for us :) >>> >>> It appears this quirk is active for a wide number of machine >>> configurations (basically all that appear under sun4m_machine_init) -= - >>> What's the risk of us breaking one of those configurations? >>> >>> How did you test SS-5? (Can we test the others similarly? Is there a >>> justification for not doing so?) >> >> According to 82407d1a4035e5bfefb53ffdcb270872f813b34c, there was >> probably a hang when SS-5 OBP firmware was initializing the floppy. I >> checked my change with the OBP SS-5 firmware 2.15, which doesn't hang >> and goes up to firmware prompt. I also tested SS-4, SS-10 (OBP v3.45) >> and SS-20 (OBP 2.25) which also go up to firmware prompt. I was unable >> to test the other platforms with OBP. >> Then, I tested SS-5 with Debian 4.0r9, and boot messages now detect th= e >> floppy controller with "Floppy drive(s): fd0 is 1.44M" and "FDC 0 is a >> S82078B" >> >> However, in 82407d1a4035e5bfefb53ffdcb270872f813b34c, floppy was >> probably not working, and is still broken after this commit. This may = be >> due to a missing DMA controller on sparc platform. > > Yeah, I'm fairly sure from Herv=C3=A9's work in this area that the exis= ting > sun4m floppy disk could never function correctly anyway. Given that thi= s > is the case, I'd be okay with having this patch applied for all sun4m > models so that it can at least be detected, and hopefully persuaded to > work with only a little more effort. > > > ATB, > > Mark. > Sounds good to me. Will stage for 2.4. Thanks, --js