From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYf0f-0006Jg-Tx for qemu-devel@nongnu.org; Thu, 19 Mar 2015 14:17:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYf0e-000891-TY for qemu-devel@nongnu.org; Thu, 19 Mar 2015 14:17:33 -0400 Message-ID: <550B12B6.9040804@redhat.com> Date: Thu, 19 Mar 2015 12:17:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1425413591-31413-1-git-send-email-mreitz@redhat.com> <1425413591-31413-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1425413591-31413-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0irlr3l7s0wisvlfpnb1OsBTQFxcHHaaJ" Subject: Re: [Qemu-devel] [PATCH v5 05/13] block: Move BDS close notifiers into BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Markus Armbruster , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0irlr3l7s0wisvlfpnb1OsBTQFxcHHaaJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/03/2015 01:13 PM, Max Reitz wrote: > The only remaining user of the BDS close notifiers is NBD which uses > them to determine when a BDS tree is being ejected. This patch removes > the BDS-level close notifiers and adds a notifier list to the > BlockBackend structure that is invoked whenever a BDS is removed. >=20 > Symmetrically to that, another notifier list is added that is invoked > whenever a BDS is inserted. The dataplane implementations for virtio-bl= k > and virtio-scsi use both notifier types for setting up and removing op > blockers. This is not only important for setting up the op blockers on > insertion, but also for removing them on ejection since bdrv_delete() > asserts that there are no op blockers set up. >=20 > Signed-off-by: Max Reitz > --- > block.c | 7 ---- > block/block-backend.c | 19 +++++++--- > blockdev-nbd.c | 36 +------------------ > hw/block/dataplane/virtio-blk.c | 77 +++++++++++++++++++++++++++++++--= -------- > hw/scsi/virtio-scsi.c | 59 +++++++++++++++++++++++++++++++ > include/block/block.h | 1 - > include/block/block_int.h | 2 -- > include/hw/virtio/virtio-scsi.h | 10 ++++++ > include/sysemu/block-backend.h | 3 +- > nbd.c | 13 +++++++ > 10 files changed, 159 insertions(+), 68 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0irlr3l7s0wisvlfpnb1OsBTQFxcHHaaJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVCxK2AAoJEKeha0olJ0NqENUIALBiujw9KrgmuRRwi8PCWPmj OqtRdOPWjuXa5qdS3fAFg8AnFblWQYRjqQCAgQalAZc4J162ToGppToIB4Ep/Pwr lVS0hUdBbh0BmymK8IuPNMye6vVRKRkv606yD5Tdf8gi7YBEeNWtanMDCX1P/yN/ 5GjG7nlB5XejLWXXJkJ19IN9/md9Eex5YSCxXfGGTxMo+emRI1Mvh9ZkTPGQbgQ1 AeOl+Wh2eCgX2iv1qEUdDL1On4iPFcP4FToiHRm1mAYTgXZd3PF2nqVPRUR5odXa JAXoWMSnSpDdm00r+OD0wiGXcrgZMBRA8mG0MmZQYpbtqKuUf0hA7o7C/cySSKE= =z0Cu -----END PGP SIGNATURE----- --0irlr3l7s0wisvlfpnb1OsBTQFxcHHaaJ--