From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYiEm-00028S-Vx for qemu-devel@nongnu.org; Thu, 19 Mar 2015 17:44:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYiEi-0007cC-2q for qemu-devel@nongnu.org; Thu, 19 Mar 2015 17:44:20 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:35745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYiEh-0007bw-SL for qemu-devel@nongnu.org; Thu, 19 Mar 2015 17:44:16 -0400 Received: by wibdy8 with SMTP id dy8so2026016wib.0 for ; Thu, 19 Mar 2015 14:44:15 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <550B432A.2030905@redhat.com> Date: Thu, 19 Mar 2015 22:44:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <55064584.4040304@cn.fujitsu.com> <20150316055709-mutt-send-email-mst@redhat.com> In-Reply-To: <20150316055709-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/7] pass aer error to guest for vfio device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Chen Fan Cc: izumi.taku@jp.fujitsu.com, alex.williamson@redhat.com, qemu-devel@nongnu.org On 16/03/2015 05:57, Michael S. Tsirkin wrote: > > 1. add 'x-aer' for user to off aer capability. > > User-exposed properties should not start with x- - by convention > that's for internal properties. Wrong, x- is for properties that we don't guarantee to remain there in the future. It looks indeed like the property should be called simply 'aer', but not for the reason you mentioned. Paolo