From: Gonglei <arei.gonglei@huawei.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pcspk: Fix I/O port name
Date: Fri, 20 Mar 2015 09:11:47 +0800 [thread overview]
Message-ID: <550B73D3.7000604@huawei.com> (raw)
In-Reply-To: <550ABC48.5060602@siemens.com>
On 2015/3/19 20:08, Jan Kiszka wrote:
> Probably a copy&paste bug. Fixing it helps identifying the device model
> behind port 0x61.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/audio/pcspk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
> diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
> index 1d81bbe..5266fb5 100644
> --- a/hw/audio/pcspk.c
> +++ b/hw/audio/pcspk.c
> @@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
> {
> PCSpkState *s = PC_SPEAKER(obj);
>
> - memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
> + memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
> }
>
> static void pcspk_realizefn(DeviceState *dev, Error **errp)
>
next prev parent reply other threads:[~2015-03-20 1:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 12:08 [Qemu-devel] [PATCH] pcspk: Fix I/O port name Jan Kiszka
2015-03-20 1:11 ` Gonglei [this message]
2015-03-25 15:15 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B73D3.7000604@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).