From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39114)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YYlU9-0004F7-8O
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 21:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YYlU8-0001NU-Bc
	for qemu-devel@nongnu.org; Thu, 19 Mar 2015 21:12:25 -0400
Message-ID: <550B73D3.7000604@huawei.com>
Date: Fri, 20 Mar 2015 09:11:47 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <550ABC48.5060602@siemens.com>
In-Reply-To: <550ABC48.5060602@siemens.com>
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] pcspk: Fix I/O port name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-trivial <qemu-trivial@nongnu.org>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 2015/3/19 20:08, Jan Kiszka wrote:
> Probably a copy&paste bug. Fixing it helps identifying the device model
> behind port 0x61.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/audio/pcspk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Gonglei <arei.gonglei@huawei.com>

> diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
> index 1d81bbe..5266fb5 100644
> --- a/hw/audio/pcspk.c
> +++ b/hw/audio/pcspk.c
> @@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
>  {
>      PCSpkState *s = PC_SPEAKER(obj);
>  
> -    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
> +    memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
>  }
>  
>  static void pcspk_realizefn(DeviceState *dev, Error **errp)
>