Re: [Qemu-devel] [PATCH V6 for-2.3 00/26] hw/pc: implement multiple primary busses for pc machines

[Marcel Apfelbaum <marcel@redhat.com>]

On 03/19/2015 11:45 PM, Paolo Bonzini wrote:
>
>
> On 19/03/2015 19:52, Marcel Apfelbaum wrote:
>>   hw/pci-host/piix.c                  | 128 ++++++++-
>>   hw/pci-host/ppce500.c               |   1 +
>>   hw/pci-host/q35.c                   |   5 +
>>   hw/pci-host/uninorth.c              |   1 +
>>   hw/pci/Makefile.objs                |   2 +-
>>   hw/pci/pci.c                        | 493 +---------------------------------
>>   hw/pci/pci_bus.c                    | 517 ++++++++++++++++++++++++++++++++++++
>>   hw/pci/pci_host.c                   |  42 +++
>>   hw/ppc/ppc4xx_pci.c                 |   1 +
>>   hw/scsi/megasas.c                   |   1 +
>>   hw/sh4/r2d.c                        |   1 +
>>   hw/sh4/sh_pci.c                     |   1 +
>>   hw/vfio/pci.c                       |   1 +
>>   hw/xen/xen_pt.c                     |   1 +
>>   include/hw/acpi/aml-build.h         |   8 +
>>   include/hw/i386/pc.h                |   8 +-
>>   include/hw/pci/pci.h                |   6 +-
>>   include/hw/pci/pci_bus.h            |  35 +++
>>   include/hw/pci/pci_host.h           |  34 +++
>>   include/sysemu/sysemu.h             |   1 +
>>   32 files changed, 1508 insertions(+), 510 deletions(-)
>
> I think this should not be committed to 2.3 after -rc0.
While I agree that looking at the above the series do not
fit for 2.3, I still think the risk is not big because:
- The biggest amount of modifications are in pci_bus/pci_host
   and *is only*  a movement of code into a new file,
   no changes at all (This cover almost half of the series changes)
- The series does not intervene with usual process, meaning if
   pxb is not used, it will work exactly like before
- The bios already supports pxb for this release, is a pity to wait
   for another QEMU version.
- The series were in mailing list for more than a month before rc,
   but the real review process started at rc time.
   (begging the question what a non-maintainer must do to get its code in time)
- The series is mature, rebased on the latest QEMU
   and was reviewed in depth and tested by the community.

The above being said, I'll agree with whatever the maintainers will decide.

Thanks,
Marcel

>
> Paolo
>