From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYvLF-0007gO-51 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 07:43:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYvL9-0000DE-QW for qemu-devel@nongnu.org; Fri, 20 Mar 2015 07:43:53 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:55499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYvL9-0000D1-Hw for qemu-devel@nongnu.org; Fri, 20 Mar 2015 07:43:47 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Mar 2015 05:43:46 -0600 Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 70D7D38C8041 for ; Fri, 20 Mar 2015 07:43:44 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2KBhipb30277868 for ; Fri, 20 Mar 2015 11:43:44 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2KBhhAw017856 for ; Fri, 20 Mar 2015 07:43:43 -0400 Message-ID: <550C07EF.6010105@linux.vnet.ibm.com> Date: Fri, 20 Mar 2015 07:43:43 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> <1426769810.610.64.camel@citrix.com> In-Reply-To: <1426769810.610.64.camel@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Campbell , Quan Xu Cc: kevin@koconnor.net, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org On 03/19/2015 08:56 AM, Ian Campbell wrote: > On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: >> @@ -151,6 +152,8 @@ device_hardware_setup(void) >> esp_scsi_setup(); >> megasas_setup(); >> pvscsi_setup(); >> + if (runningOnXen()) >> + vtpm4hvm_setup(); > Is there anything which is actually Xen specific about the driver in > tpm.[ch]? Would it be better to just probe for it, perhaps gates by a > Kconfig option which enables TPM support. I also think the probing should be done. That code can also be recycled from what I posted earlier. It's gated by a Kconfig option, so it doesn't fill up the 128k ROM. Stefan > > And following that train of thought I think you could reasonable drop > "4hvm" from the name. And possibly even the leading "v", since I suppose > seabios shouldn't really care if the tpm is emulated or real so long as > it looks like a real tpm. > > Ian. >