From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYvbn-0004VV-Vw for qemu-devel@nongnu.org; Fri, 20 Mar 2015 08:01:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYvbj-0005yI-L6 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 08:00:59 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:40788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYvbj-0005ud-IH for qemu-devel@nongnu.org; Fri, 20 Mar 2015 08:00:55 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Mar 2015 08:00:53 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id BE3A76E8040 for ; Fri, 20 Mar 2015 07:52:40 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2KC0oxM21626996 for ; Fri, 20 Mar 2015 12:00:50 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2KC0l11020434 for ; Fri, 20 Mar 2015 08:00:50 -0400 Message-ID: <550C0BEF.3000409@linux.vnet.ibm.com> Date: Fri, 20 Mar 2015 08:00:47 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> <1426769810.610.64.camel@citrix.com> <945CA011AD5F084CBEA3E851C0AB28890E8C5EE4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28890E8C5EE4@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Xu, Quan" , Ian Campbell Cc: "kevin@koconnor.net" , "qemu-devel@nongnu.org" , "stefano.stabellini@eu.citrix.com" , "xen-devel@lists.xen.org" On 03/19/2015 09:35 PM, Xu, Quan wrote: > >> -----Original Message----- >> From: Ian Campbell [mailto:ian.campbell@citrix.com] >> Sent: Thursday, March 19, 2015 8:57 PM >> To: Xu, Quan >> Cc: kevin@koconnor.net; stefanb@linux.vnet.ibm.com; xen-devel@lists.xen.org; >> qemu-devel@nongnu.org; stefano.stabellini@eu.citrix.com >> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for >> HVM virtual machine >> >> On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: >>> @@ -151,6 +152,8 @@ device_hardware_setup(void) >>> esp_scsi_setup(); >>> megasas_setup(); >>> pvscsi_setup(); >>> + if (runningOnXen()) >>> + vtpm4hvm_setup(); >> Is there anything which is actually Xen specific about the driver in tpm.[ch]? >> Would it be better to just probe for it, perhaps gates by a Kconfig option which >> enables TPM support. >> >> And following that train of thought I think you could reasonable drop "4hvm" >> from the name. And possibly even the leading "v", since I suppose seabios >> shouldn't really care if the tpm is emulated or real so long as it looks like a real >> tpm. >> >> Ian. > Thanks for your review. Make sense. > > Quan From previously posted patches you should be able to take 1/8 with the driver: http://www.seabios.org/pipermail/seabios/2014-July/008179.html 2/8 added ACPI support, but this is not necessary; it contained the probing parts, which could be merged into 1. 3/8 was doing TPM initialization, so that should be recyclable as well: http://www.seabios.org/pipermail/seabios/2014-July/008180.html I have a set of patches that removes the ACPI part in 2/8, though didn't post it. Stefan