From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYxPQ-0002M0-TR for qemu-devel@nongnu.org; Fri, 20 Mar 2015 09:56:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYxPM-0008ST-QK for qemu-devel@nongnu.org; Fri, 20 Mar 2015 09:56:20 -0400 Message-ID: <550C26FE.6010807@redhat.com> Date: Fri, 20 Mar 2015 07:56:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426856744-18750-1-git-send-email-armbru@redhat.com> <1426856744-18750-2-git-send-email-armbru@redhat.com> <550C21DB.8000607@redhat.com> <87h9tf7pbi.fsf@blackfin.pond.sub.org> <550C2577.2010201@redhat.com> In-Reply-To: <550C2577.2010201@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9SN48cwBTQA7iOd4x4jkFsdGDmdAdtBKJ" Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 1/1] block: New command line option --no-format-probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Markus Armbruster Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9SN48cwBTQA7iOd4x4jkFsdGDmdAdtBKJ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/20/2015 07:49 AM, Max Reitz wrote: >>>> Disabling probing entirely is a (hamfisted) way to ensure you always= >>>> specify the format. >>>> >> >> I'd appreciate opinions on whether this is wanted for 2.3. If it is, >> I'll post a version that actually works. >=20 > I don't have any objections because it won't break anything. But I gues= s > it'll be mostly up to whether Eric thinks that we'll need it right now.= I'm totally in favor of the idea; it has no drawback to users that don't add it to the command line (so no chance of regression to existing command lines), and allows users that care to ensure that they are being secure. And I can argue that this is a bug fix rather than a feature and therefore appropriate even in freeze (even though the bug has been a long-standing security hole, rather than a recent regression). If (a working version of) this makes it in 2.3, libvirt WILL use it in the next release. It will take me less than 5 minutes to write up the libvirt patch, as long as the new option is advertised via query-command-line-options (which means that QMP introspection of the new option is a must for v2 :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9SN48cwBTQA7iOd4x4jkFsdGDmdAdtBKJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVDCb+AAoJEKeha0olJ0NqxkEH/17/nODrOBIDvhEpyvmw7ErD WusHGMyKCGLOGfKnqQIorfLYHDyJIOCGkRb+w8QGJMlw8awPqiTmvVfSr4GmXgd5 9qVO8krxxEKSgOfUTfJqbXbevEJt3Oi7fYNIH2t8TMQpvDPK3+5zp8nc/BG7k0W8 dt0RYhHr2FxzAXXf0Yfb0QUJ5PQXd0mpp2DjKfRf9szu3yhSSWEBDI62SbUHhwrW TfKIj1BFeTz9+5XHOwzvKqc41eCAlk3aYau2kLHZrpRxHjhscMIlEp9FP39S+MJC XDwimvQTVmR18qksFIo6dJGPnFBSZyXBixW5cDhftj7RUwefVrTR4H3nBk7hA+E= =WK4Y -----END PGP SIGNATURE----- --9SN48cwBTQA7iOd4x4jkFsdGDmdAdtBKJ--