From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing
Date: Fri, 20 Mar 2015 08:01:01 -0600 [thread overview]
Message-ID: <550C281D.3070300@redhat.com> (raw)
In-Reply-To: <1426856744-18750-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On 03/20/2015 07:05 AM, Markus Armbruster wrote:
> First of all, my apologies for being so late with this. I realized
> part way through the current development cycle that I couldn't do both
> the error work and my half of the block probing work we discussed back
> in November, so I punted the latter to the next cycle, missing the one
> little feature I quite obviously could do.
>
> Why is this "RFC for-2.3"? The patch is simple, and quite obviously
> does nothing unless you run with --no-format-probing. If libvirt
> wants it in 2.3, then I think we should consider it even at this late
> stage. If libvirt doesn't want it, or won't try to make use of it for
> another few months, I'm happy to drop the patch now and revisit the
> larger topic in the next cycle.
>
> I readily admit --no-format-probing is fugly. Better ideas are
> welcome.
So, is it spelled '--no-format-probing', or is it spelled
'-no-format-probing'? It is in the same category as other flag
parameters like '-enable-fips' or '-no-user-config'.
>
> Markus Armbruster (1):
> block: New command line option --no-format-probing
>
> block.c | 9 ++++++++-
> include/block/block.h | 2 +-
> qemu-options.hx | 12 ++++++++++++
> vl.c | 6 +++++-
> 4 files changed, 26 insertions(+), 3 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-03-20 14:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:05 [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing Markus Armbruster
2015-03-20 13:05 ` [Qemu-devel] [PATCH RFC for-2.3 1/1] " Markus Armbruster
2015-03-20 13:34 ` Max Reitz
2015-03-20 13:48 ` Markus Armbruster
2015-03-20 13:49 ` Max Reitz
2015-03-20 13:56 ` Eric Blake
2015-03-20 14:19 ` Markus Armbruster
2015-03-20 14:32 ` Eric Blake
2015-03-23 17:23 ` Paolo Bonzini
2015-03-23 17:48 ` Eric Blake
2015-03-23 17:50 ` Paolo Bonzini
2015-03-23 20:19 ` Markus Armbruster
2015-03-24 8:37 ` Paolo Bonzini
2015-03-24 14:22 ` [Qemu-devel] [Qemu-block] " Eric Blake
2015-03-24 16:49 ` [Qemu-devel] " Markus Armbruster
2015-03-24 20:11 ` Paolo Bonzini
2015-03-25 8:10 ` Markus Armbruster
2015-03-25 10:36 ` Paolo Bonzini
2015-03-20 14:01 ` Eric Blake [this message]
2015-03-20 14:27 ` [Qemu-devel] [PATCH RFC for-2.3 0/1] " Markus Armbruster
2015-03-20 14:17 ` [Qemu-devel] [RFC PATCH] qemu: enforce no format probing when possible Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C281D.3070300@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).