From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYxUB-0002HY-88 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 10:01:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYxU5-0001RH-C5 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 10:01:15 -0400 Message-ID: <550C281D.3070300@redhat.com> Date: Fri, 20 Mar 2015 08:01:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1426856744-18750-1-git-send-email-armbru@redhat.com> In-Reply-To: <1426856744-18750-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K0kn5RSvBCVVrjXBXWqL0oSOKQda9gQd6" Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 0/1] block: New command line option --no-format-probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K0kn5RSvBCVVrjXBXWqL0oSOKQda9gQd6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/20/2015 07:05 AM, Markus Armbruster wrote: > First of all, my apologies for being so late with this. I realized > part way through the current development cycle that I couldn't do both > the error work and my half of the block probing work we discussed back > in November, so I punted the latter to the next cycle, missing the one > little feature I quite obviously could do. >=20 > Why is this "RFC for-2.3"? The patch is simple, and quite obviously > does nothing unless you run with --no-format-probing. If libvirt > wants it in 2.3, then I think we should consider it even at this late > stage. If libvirt doesn't want it, or won't try to make use of it for > another few months, I'm happy to drop the patch now and revisit the > larger topic in the next cycle. >=20 > I readily admit --no-format-probing is fugly. Better ideas are > welcome. So, is it spelled '--no-format-probing', or is it spelled '-no-format-probing'? It is in the same category as other flag parameters like '-enable-fips' or '-no-user-config'. >=20 > Markus Armbruster (1): > block: New command line option --no-format-probing >=20 > block.c | 9 ++++++++- > include/block/block.h | 2 +- > qemu-options.hx | 12 ++++++++++++ > vl.c | 6 +++++- > 4 files changed, 26 insertions(+), 3 deletions(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K0kn5RSvBCVVrjXBXWqL0oSOKQda9gQd6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVDCgdAAoJEKeha0olJ0NqEokIAJbT0dJXZqm0/TAmfguUjMtd B5tobBU9p31l2gnlIqlVzvq1LSs/ygWi8kd1W2sciqbnt/RvePH+HkVPNiEQX6id SFBlsKFkdYSzKzdQNxDu+WXYrYkj84ccFfVh5YCz5axpHcF5qj0MXL94Yf/CIq6i KvOAHXukCRsf6CjvWaZWGio4/BFDm+jY2nK/BoMcmDRPjUCPdsT9yTtlmW/gTvIW 2Sr67hd18BjnMl/hEHWUKwVFzCxQmsFXzTaKZXs1wBYmFd23I82UcNJjpqbc412h mZGXMhiKK+cJWLE3hNz0xpMJKAySDXIZGvajMasnBFxB3oqNEDeqhbsCu/+H9U8= =l8vS -----END PGP SIGNATURE----- --K0kn5RSvBCVVrjXBXWqL0oSOKQda9gQd6--