Re: [Qemu-devel] [PATCH] target-tricore: fix DVINIT_HU/BU calculating overflow before result

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

On 03/20/2015 02:34 PM, Bastian Koppelmann wrote:
> dvinit_hu/bu for ISA v1.3 calculate the higher part of the result, that is needed
> for the overflow bits, after calculating the overflow bits.
>
> Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> ---
>   target-tricore/translate.c | 29 +++++++++++++++++------------
>   1 file changed, 17 insertions(+), 12 deletions(-)
>
> diff --git a/target-tricore/translate.c b/target-tricore/translate.c
> index 0b7cf06..d3680c3 100644
> --- a/target-tricore/translate.c
> +++ b/target-tricore/translate.c
> @@ -6240,7 +6240,7 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
>       uint32_t op2;
>       int r1, r2, r3;
>   
> -    TCGv temp, temp2;
> +    TCGv temp, temp2, temp3;
>   
>       op2 = MASK_OP_RR_OP2(ctx->opcode);
>       r3 = MASK_OP_RR_D(ctx->opcode);
> @@ -6261,14 +6261,17 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
>       case OPC2_32_RR_DVINIT_BU:
>           temp = tcg_temp_new();
>           temp2 = tcg_temp_new();
> +        temp3 = tcg_temp_new();
> +
> +        tcg_gen_shri_tl(temp3, cpu_gpr_d[r1], 8);
>           /* reset av */
>           tcg_gen_movi_tl(cpu_PSW_AV, 0);
>           if (!tricore_feature(env, TRICORE_FEATURE_131)) {
>               /* overflow = (abs(D[r3+1]) >= abs(D[r2])) */
> -            tcg_gen_neg_tl(temp, cpu_gpr_d[r3+1]);
> +            tcg_gen_neg_tl(temp, temp3);
>               /* use cpu_PSW_AV to compare against 0 */
> -            tcg_gen_movcond_tl(TCG_COND_LT, temp, cpu_gpr_d[r3+1], cpu_PSW_AV,
> -                               temp, cpu_gpr_d[r3+1]);
> +            tcg_gen_movcond_tl(TCG_COND_LT, temp, temp3, cpu_PSW_AV,
> +                               temp, temp3);
>               tcg_gen_neg_tl(temp2, cpu_gpr_d[r2]);
>               tcg_gen_movcond_tl(TCG_COND_LT, temp2, cpu_gpr_d[r2], cpu_PSW_AV,
>                                  temp2, cpu_gpr_d[r2]);
> @@ -6281,9 +6284,8 @@ static void decode_rr_divide(CPUTriCoreState *env, DisasContext *ctx)
>           /* sv */
>           tcg_gen_or_tl(cpu_PSW_SV, cpu_PSW_SV, cpu_PSW_V);
>           /* write result */
> -        tcg_gen_shri_tl(temp, cpu_gpr_d[r1], 8);
>           tcg_gen_shli_tl(cpu_gpr_d[r3], cpu_gpr_d[r1], 24);
> -        tcg_gen_mov_tl(cpu_gpr_d[r3+1], temp);
> +        tcg_gen_mov_tl(cpu_gpr_d[r3+1], temp3);
>   
>           tcg_temp_free(temp);
>           tcg_temp_free(temp2);
>
Mh, I forgot to free temp3 here. I'll change that after I applied it to 
my tricore-next branch.

Cheers,
Bastian