qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures
Date: Fri, 20 Mar 2015 18:44:35 +0100	[thread overview]
Message-ID: <550C5C83.2040204@suse.de> (raw)
In-Reply-To: <1426811056-2202-1-git-send-email-jsnow@redhat.com>

Am 20.03.2015 um 01:24 schrieb John Snow:
> Two issues were unearthed from ahci-test on ppc64:
> 
> (1) The ahci_populate_sglist function had endian issues,
>     which is only likely to impact PIO transfers for buffers
>     greater than one sector, and
> 
> (2) multiple-sector PIO which I attempted to repair in
>     36334faf has been broken for years. ahci-test didn't catch
>     this because it used a pattern that was identical for each
>     sector.
> 
>     So the pattern has been corrected and the underlying issue
>     fixed.
> 
> This should clear up the test failures (properly) for ppc64.
> 
> John Snow (4):
>   ide: fix cmd_write_pio when nsectors > 1
>   ide: fix cmd_read_pio when nsectors > 1
>   ahci: Fix sglist offset manipulation for BE machines
>   ahci-test: improve rw buffer patterns

Confirming that it resolves the observed failure,

Tested-by: Andreas Färber <afaerber@suse.de>

Thanks for the quick fix,

Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

  parent reply	other threads:[~2015-03-20 17:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20  0:24 [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures John Snow
2015-03-20  0:24 ` [Qemu-devel] [PATCH for-2.3 1/4] ide: fix cmd_write_pio when nsectors > 1 John Snow
2015-03-20  0:24 ` [Qemu-devel] [PATCH for-2.3 2/4] ide: fix cmd_read_pio " John Snow
2015-03-20  0:24 ` [Qemu-devel] [PATCH for-2.3 3/4] ahci: Fix sglist offset manipulation for BE machines John Snow
2015-03-20  0:24 ` [Qemu-devel] [PATCH for-2.3 4/4] ahci-test: improve rw buffer patterns John Snow
2015-03-20 17:44 ` Andreas Färber [this message]
2015-03-23 15:16 ` [Qemu-devel] [PATCH for-2.3 0/4] ahci: fix big endian PIO failures Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550C5C83.2040204@suse.de \
    --to=afaerber@suse.de \
    --cc=jsnow@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).