From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33516)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YZ2Wu-0004I2-47
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 15:24:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YZ2Wp-0005el-2c
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 15:24:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56846)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YZ2Wo-0005ee-Tf
	for qemu-devel@nongnu.org; Fri, 20 Mar 2015 15:24:19 -0400
Message-ID: <550C73E1.6000202@redhat.com>
Date: Fri, 20 Mar 2015 15:24:17 -0400
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <cover.1426861657.git.berto@igalia.com>
	<6e58c40ed94e7a939b9b64d16d41fdc198183788.1426861657.git.berto@igalia.com>
In-Reply-To: <6e58c40ed94e7a939b9b64d16d41fdc198183788.1426861657.git.berto@igalia.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] block: use
 bdrv_get_device_or_node_name() in error messages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-03-20 at 10:33, Alberto Garcia wrote:
> There are several error messages that identify a BlockDriverState by
> its device name. However those errors can be produced in nodes that
> don't have a device name associated.
>
> In those cases we should use bdrv_get_device_or_node_name() to fall
> back to the node name and produce a more meaningful message. The
> messages are also updated to use the more generic term 'node' instead
> of 'device'.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
>   block.c                   | 24 ++++++++++++------------
>   block/qcow.c              |  8 ++++----
>   block/qcow2.c             |  2 +-
>   block/qed.c               |  2 +-
>   block/snapshot.c          | 12 ++++++------
>   block/vdi.c               |  6 +++---
>   block/vhdx.c              |  6 +++---
>   block/vmdk.c              |  8 ++++----
>   block/vpc.c               |  6 +++---
>   block/vvfat.c             |  7 ++++---
>   blockdev.c                |  9 +++++----
>   include/qapi/qmp/qerror.h |  6 ------
>   12 files changed, 46 insertions(+), 50 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>