From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZ2wu-0007AT-0B for qemu-devel@nongnu.org; Fri, 20 Mar 2015 15:51:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZ2wn-0007Ti-FQ for qemu-devel@nongnu.org; Fri, 20 Mar 2015 15:51:15 -0400 Message-ID: <550C7A2A.3080705@redhat.com> Date: Fri, 20 Mar 2015 15:51:06 -0400 From: Max Reitz MIME-Version: 1.0 References: <1426879023-18151-1-git-send-email-jsnow@redhat.com> <1426879023-18151-21-git-send-email-jsnow@redhat.com> In-Reply-To: <1426879023-18151-21-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 20/20] iotests: add incremental backup failure recovery test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-03-20 at 15:17, John Snow wrote: > Test the failure case for incremental backups. > > Signed-off-by: John Snow > --- > blockdev.c | 1 - > tests/qemu-iotests/124 | 55 ++++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/124.out | 4 ++-- > 3 files changed, 57 insertions(+), 3 deletions(-) > > diff --git a/blockdev.c b/blockdev.c > index b9c79ed..ab67b4d 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -1218,7 +1218,6 @@ static BdrvDirtyBitmap *block_dirty_bitmap_lookup(const char *node, > } else { > aio_context_release(aio_context); > } > - > return bitmap; > > fail: This doesn't look like it belongs here... With that hunk removed (whether by maintainer or by you): Reviewed-by: Max Reitz