From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59927) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZKON-0004TT-7p for qemu-devel@nongnu.org; Sat, 21 Mar 2015 10:28:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZKOM-0003C0-EL for qemu-devel@nongnu.org; Sat, 21 Mar 2015 10:28:47 -0400 Sender: Paolo Bonzini Message-ID: <550D8014.2020000@redhat.com> Date: Sat, 21 Mar 2015 15:28:36 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426919112-20726-1-git-send-email-cota@braap.org> In-Reply-To: <1426919112-20726-1-git-send-email-cota@braap.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Emilio G. Cota" , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org On 21/03/2015 07:25, Emilio G. Cota wrote: > It always evaluates to true. > > Signed-off-by: Emilio G. Cota > --- > translate-all.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index 9f47ce7..11763c6 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb, > p->first_tb = (TranslationBlock *)((uintptr_t)tb | n); > invalidate_page_bitmap(p); > > -#if defined(TARGET_HAS_SMC) || 1 > - > #if defined(CONFIG_USER_ONLY) > if (p->flags & PAGE_WRITE) { > target_ulong addr; > @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb, > tlb_protect_code(page_addr); > } > #endif > - > -#endif /* TARGET_HAS_SMC */ > } > > /* add a new TB and link it to the physical page tables. phys_page2 is > You are removing the last use of TARGET_HAS_SMC, please remove the definition as well. Paolo