From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZLSF-00024G-5a for qemu-devel@nongnu.org; Sat, 21 Mar 2015 11:36:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZLSA-0007Xm-2b for qemu-devel@nongnu.org; Sat, 21 Mar 2015 11:36:51 -0400 Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:33233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZLS9-0007Xi-Rh for qemu-devel@nongnu.org; Sat, 21 Mar 2015 11:36:45 -0400 Received: by wgbcc7 with SMTP id cc7so112215132wgb.0 for ; Sat, 21 Mar 2015 08:36:45 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <550D9008.1050808@redhat.com> Date: Sat, 21 Mar 2015 16:36:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426787272-17921-1-git-send-email-afaerber@suse.de> In-Reply-To: <1426787272-17921-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-2.3] fw_cfg-test: Fix test path to include architecture List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: Peter Maydell On 19/03/2015 18:47, Andreas Färber wrote: > Use qtest_add_func() instead of g_test_add_func() to reflect > the architecture tested, changing GTester paths as follows: > > /fw_cfg/foo -> /x86_64/fw_cfg/foo etc. > > Signed-off-by: Andreas Färber > --- > tests/fw_cfg-test.c | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c > index 5c8f8d6..9be78e9 100644 > --- a/tests/fw_cfg-test.c > +++ b/tests/fw_cfg-test.c > @@ -109,21 +109,21 @@ int main(int argc, char **argv) > > fw_cfg = pc_fw_cfg_init(); > > - g_test_add_func("/fw_cfg/signature", test_fw_cfg_signature); > - g_test_add_func("/fw_cfg/id", test_fw_cfg_id); > - g_test_add_func("/fw_cfg/uuid", test_fw_cfg_uuid); > - g_test_add_func("/fw_cfg/ram_size", test_fw_cfg_ram_size); > - g_test_add_func("/fw_cfg/nographic", test_fw_cfg_nographic); > - g_test_add_func("/fw_cfg/nb_cpus", test_fw_cfg_nb_cpus); > + qtest_add_func("fw_cfg/signature", test_fw_cfg_signature); > + qtest_add_func("fw_cfg/id", test_fw_cfg_id); > + qtest_add_func("fw_cfg/uuid", test_fw_cfg_uuid); > + qtest_add_func("fw_cfg/ram_size", test_fw_cfg_ram_size); > + qtest_add_func("fw_cfg/nographic", test_fw_cfg_nographic); > + qtest_add_func("fw_cfg/nb_cpus", test_fw_cfg_nb_cpus); > #if 0 > - g_test_add_func("/fw_cfg/machine_id", test_fw_cfg_machine_id); > - g_test_add_func("/fw_cfg/kernel", test_fw_cfg_kernel); > - g_test_add_func("/fw_cfg/initrd", test_fw_cfg_initrd); > - g_test_add_func("/fw_cfg/boot_device", test_fw_cfg_boot_device); > + qtest_add_func("fw_cfg/machine_id", test_fw_cfg_machine_id); > + qtest_add_func("fw_cfg/kernel", test_fw_cfg_kernel); > + qtest_add_func("fw_cfg/initrd", test_fw_cfg_initrd); > + qtest_add_func("fw_cfg/boot_device", test_fw_cfg_boot_device); > #endif > - g_test_add_func("/fw_cfg/max_cpus", test_fw_cfg_max_cpus); > - g_test_add_func("/fw_cfg/numa", test_fw_cfg_numa); > - g_test_add_func("/fw_cfg/boot_menu", test_fw_cfg_boot_menu); > + qtest_add_func("fw_cfg/max_cpus", test_fw_cfg_max_cpus); > + qtest_add_func("fw_cfg/numa", test_fw_cfg_numa); > + qtest_add_func("fw_cfg/boot_menu", test_fw_cfg_boot_menu); > > cmdline = g_strdup_printf("-uuid 4600cb32-38ec-4b2f-8acb-81c6ea54f2d8 "); > s = qtest_start(cmdline); > Reviewed-by: Paolo Bonzini