* [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1
@ 2015-03-21 6:25 Emilio G. Cota
2015-03-21 14:28 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Emilio G. Cota @ 2015-03-21 6:25 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
It always evaluates to true.
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
translate-all.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 9f47ce7..11763c6 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
invalidate_page_bitmap(p);
-#if defined(TARGET_HAS_SMC) || 1
-
#if defined(CONFIG_USER_ONLY)
if (p->flags & PAGE_WRITE) {
target_ulong addr;
@@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
tlb_protect_code(page_addr);
}
#endif
-
-#endif /* TARGET_HAS_SMC */
}
/* add a new TB and link it to the physical page tables. phys_page2 is
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1
2015-03-21 6:25 [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1 Emilio G. Cota
@ 2015-03-21 14:28 ` Paolo Bonzini
2015-03-21 17:29 ` [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro Emilio G. Cota
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2015-03-21 14:28 UTC (permalink / raw)
To: Emilio G. Cota, qemu-devel; +Cc: qemu-trivial
On 21/03/2015 07:25, Emilio G. Cota wrote:
> It always evaluates to true.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> translate-all.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
> invalidate_page_bitmap(p);
>
> -#if defined(TARGET_HAS_SMC) || 1
> -
> #if defined(CONFIG_USER_ONLY)
> if (p->flags & PAGE_WRITE) {
> target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> tlb_protect_code(page_addr);
> }
> #endif
> -
> -#endif /* TARGET_HAS_SMC */
> }
>
> /* add a new TB and link it to the physical page tables. phys_page2 is
>
You are removing the last use of TARGET_HAS_SMC, please remove the
definition as well.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro
2015-03-21 14:28 ` Paolo Bonzini
@ 2015-03-21 17:29 ` Emilio G. Cota
2015-03-21 18:45 ` Paolo Bonzini
2015-03-25 15:16 ` Michael Tokarev
0 siblings, 2 replies; 5+ messages in thread
From: Emilio G. Cota @ 2015-03-21 17:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Paolo Bonzini
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
target-i386/cpu.h | 2 --
translate-all.c | 4 ----
2 files changed, 6 deletions(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
index 15db6d7..4ee12ca 100644
--- a/target-i386/cpu.h
+++ b/target-i386/cpu.h
@@ -31,8 +31,6 @@
/* Maximum instruction code size */
#define TARGET_MAX_INSN_SIZE 16
-/* target supports implicit self modifying code */
-#define TARGET_HAS_SMC
/* support for self modifying code even if the modified instruction is
close to the modifying instruction */
#define TARGET_HAS_PRECISE_SMC
diff --git a/translate-all.c b/translate-all.c
index 9f47ce7..11763c6 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
invalidate_page_bitmap(p);
-#if defined(TARGET_HAS_SMC) || 1
-
#if defined(CONFIG_USER_ONLY)
if (p->flags & PAGE_WRITE) {
target_ulong addr;
@@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
tlb_protect_code(page_addr);
}
#endif
-
-#endif /* TARGET_HAS_SMC */
}
/* add a new TB and link it to the physical page tables. phys_page2 is
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro
2015-03-21 17:29 ` [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro Emilio G. Cota
@ 2015-03-21 18:45 ` Paolo Bonzini
2015-03-25 15:16 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-03-21 18:45 UTC (permalink / raw)
To: Emilio G. Cota, qemu-devel; +Cc: qemu-trivial
On 21/03/2015 18:29, Emilio G. Cota wrote:
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> target-i386/cpu.h | 2 --
> translate-all.c | 4 ----
> 2 files changed, 6 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 15db6d7..4ee12ca 100644
> --- a/target-i386/cpu.h
> +++ b/target-i386/cpu.h
> @@ -31,8 +31,6 @@
> /* Maximum instruction code size */
> #define TARGET_MAX_INSN_SIZE 16
>
> -/* target supports implicit self modifying code */
> -#define TARGET_HAS_SMC
> /* support for self modifying code even if the modified instruction is
> close to the modifying instruction */
> #define TARGET_HAS_PRECISE_SMC
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
> invalidate_page_bitmap(p);
>
> -#if defined(TARGET_HAS_SMC) || 1
> -
> #if defined(CONFIG_USER_ONLY)
> if (p->flags & PAGE_WRITE) {
> target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> tlb_protect_code(page_addr);
> }
> #endif
> -
> -#endif /* TARGET_HAS_SMC */
> }
>
> /* add a new TB and link it to the physical page tables. phys_page2 is
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro
2015-03-21 17:29 ` [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro Emilio G. Cota
2015-03-21 18:45 ` Paolo Bonzini
@ 2015-03-25 15:16 ` Michael Tokarev
1 sibling, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2015-03-25 15:16 UTC (permalink / raw)
To: Emilio G. Cota, qemu-devel, mjt; +Cc: qemu-trivial, Paolo Bonzini
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-03-25 15:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-21 6:25 [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1 Emilio G. Cota
2015-03-21 14:28 ` Paolo Bonzini
2015-03-21 17:29 ` [Qemu-devel] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro Emilio G. Cota
2015-03-21 18:45 ` Paolo Bonzini
2015-03-25 15:16 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).