From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZOwy-00011k-I6 for qemu-devel@nongnu.org; Sat, 21 Mar 2015 15:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YZOwv-0003SU-CC for qemu-devel@nongnu.org; Sat, 21 Mar 2015 15:20:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40099 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YZOwv-0003Rx-5y for qemu-devel@nongnu.org; Sat, 21 Mar 2015 15:20:45 -0400 Message-ID: <550DC48A.9010505@suse.de> Date: Sat, 21 Mar 2015 20:20:42 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1426961592-4446-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1426961592-4446-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] rcu tests: fix compilation on 32-bit ppc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Am 21.03.2015 um 19:13 schrieb Paolo Bonzini: > 32-bit PPC cannot do atomic operations on long long. Inside the loops, > we are already using local counters that are summed at the end of > the run---with some exceptions (rcu_stress_count for rcutorture, > n_nodes for test-rcu-list): fix them to use the same technique. > For test-rcu-list, remove the mostly unused member "val" from the > list. Then, use a mutex to protect the global counts. >=20 > Performance does not matter there because every thread will only enter > the critical section once. >=20 > Remaining uses of atomic instructions are for ints or pointers. >=20 > Reported-by: Andreas Faerber > Signed-off-by: Paolo Bonzini > --- > tests/rcutorture.c | 20 ++++++++++++++++---- > tests/test-rcu-list.c | 42 ++++++++++++++++++++++-------------------- > 2 files changed, 38 insertions(+), 24 deletions(-) Still two errors in test-rcu-list: [ 1365s] tests/test-rcu-list.o: In function `rcu_qtest_init': [ 1365s] /home/abuild/rpmbuild/BUILD/qemu-2.3.0-rc0/tests/test-rcu-list.c:201: undefined reference to `__sync_fetch_and_add_8' [ 1365s] tests/test-rcu-list.o: In function `rcu_qtest': [ 1365s] /home/abuild/rpmbuild/BUILD/qemu-2.3.0-rc0/tests/test-rcu-list.c:237: undefined reference to `__sync_fetch_and_add_8' [ 1365s] collect2: error: ld returned 1 exit status [ 1365s] make: *** [tests/test-rcu-list] Error 1 https://build.opensuse.org/package/live_build_log/home:a_faerber:branches= :Virtualization/qemu/openSUSE_13.1/ppc Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)