From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya02z-0003JC-Gh for qemu-devel@nongnu.org; Mon, 23 Mar 2015 06:57:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya02v-00041f-6C for qemu-devel@nongnu.org; Mon, 23 Mar 2015 06:57:29 -0400 Received: from e18.ny.us.ibm.com ([129.33.205.208]:38239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya02v-00040r-1T for qemu-devel@nongnu.org; Mon, 23 Mar 2015 06:57:25 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Mar 2015 06:57:23 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 74B56C9003E for ; Mon, 23 Mar 2015 06:48:31 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2NAvLW420775106 for ; Mon, 23 Mar 2015 10:57:21 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2NAvJed018878 for ; Mon, 23 Mar 2015 06:57:20 -0400 Message-ID: <550FF18F.1010203@linux.vnet.ibm.com> Date: Mon, 23 Mar 2015 06:57:19 -0400 From: Stefan Berger MIME-Version: 1.0 References: <1425989764-2926-1-git-send-email-quan.xu@intel.com> <1425989764-2926-2-git-send-email-quan.xu@intel.com> <1426769810.610.64.camel@citrix.com> <550C07EF.6010105@linux.vnet.ibm.com> <945CA011AD5F084CBEA3E851C0AB28890E8C71A3@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28890E8C71A3@SHSMSX101.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for HVM virtual machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Xu, Quan" , Ian Campbell Cc: "kevin@koconnor.net" , "qemu-devel@nongnu.org" , "stefano.stabellini@eu.citrix.com" , "xen-devel@lists.xen.org" On 03/22/2015 09:47 PM, Xu, Quan wrote: > >> -----Original Message----- >> From: Stefan Berger [mailto:stefanb@linux.vnet.ibm.com] >> Sent: Friday, March 20, 2015 7:44 PM >> To: Ian Campbell; Xu, Quan >> Cc: kevin@koconnor.net; xen-devel@lists.xen.org; qemu-devel@nongnu.org; >> stefano.stabellini@eu.citrix.com >> Subject: Re: [Xen-devel] [PATCH] SeaBios/vTPM: Enable Xen stubdom vTPM for >> HVM virtual machine >> >> On 03/19/2015 08:56 AM, Ian Campbell wrote: >>> On Tue, 2015-03-10 at 08:16 -0400, Quan Xu wrote: >>>> @@ -151,6 +152,8 @@ device_hardware_setup(void) >>>> esp_scsi_setup(); >>>> megasas_setup(); >>>> pvscsi_setup(); >>>> + if (runningOnXen()) >>>> + vtpm4hvm_setup(); >>> Is there anything which is actually Xen specific about the driver in >>> tpm.[ch]? Would it be better to just probe for it, perhaps gates by a >>> Kconfig option which enables TPM support. >> I also think the probing should be done. That code can also be recycled from what >> I posted earlier. It's gated by a Kconfig option, so it doesn't fill up the 128k ROM. >> >> Stefan >> > Agree, I will do it ASAP. I reposted v9 of my series of patches. I will probably post v10 today. Please try that one then since these patches should cover Xen, QEMU (using a driver that only I can test at the moment), and to some extent bare metal system. Stefan