From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya0FA-0006Nr-Pp for qemu-devel@nongnu.org; Mon, 23 Mar 2015 07:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya0F6-0008T0-Mv for qemu-devel@nongnu.org; Mon, 23 Mar 2015 07:10:04 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:38400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya0F6-0008Rp-H9 for qemu-devel@nongnu.org; Mon, 23 Mar 2015 07:10:00 -0400 Received: by wibgn9 with SMTP id gn9so58763877wib.1 for ; Mon, 23 Mar 2015 04:10:00 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <550FF483.8020603@redhat.com> Date: Mon, 23 Mar 2015 12:09:55 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1417091366-4469-1-git-send-email-stefanha@redhat.com> <20141128124405.GJ13631@stefanha-thinkpad.redhat.com> In-Reply-To: <20141128124405.GJ13631@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 0/6] memory: make dirty_memory[] accesses atomic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Peter Maydell Cc: Juan Quintela , Richard Henderson , Stefan Hajnoczi , QEMU Developers On 28/11/2014 13:44, Stefan Hajnoczi wrote: > This is an example of what I mean. > > I'm not going to work on making TCG thread-safe in this series, and > there is no dangerous race condition in this code if we leave it as is. > > But I'm not 100% sure of all cases, so I'll audit them again. I looked at this again, and I agree that this series is not making anything worse. We have to start somewhere, so I'm thinking of queuing this series for 2.4. Making dirty bitmaps thread-safe with respect to memory hotplug can be done on top---especially since we already have a plan for that. Paolo