qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Lin Ma <lma@suse.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl
Date: Mon, 23 Mar 2015 13:52:36 +0100	[thread overview]
Message-ID: <55100C94.104@suse.de> (raw)
In-Reply-To: <1427105442-23484-1-git-send-email-lma@suse.com>

Hi Lin,

Am 23.03.2015 um 11:10 schrieb Lin Ma:
> Add can_be_deleted callback, If it is not null and returns false,
> The qmp_object_del won't delete the given object.
> 
> Signed-off-by: Lin Ma <lma@suse.com>
> ---
>  include/qom/object.h | 12 ++++++++++++
>  qmp.c                |  7 +++++++
>  qom/object.c         | 12 ++++++++++++
>  3 files changed, 31 insertions(+)

Why am I not being CC'ed here as QOM maintainer? You can use
scripts/get_maintainer.pl to assist you, or read MAINTAINERS file.

Also, when sending more than one patch, always include a cover letter
for grouping.

It further seems that this is the second version already, so you
should've used --subject-prefix="PATCH v2" and included a change log in
the cover letter.

Cf. http://wiki.qemu-project.org/Contribute/SubmitAPatch

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

  parent reply	other threads:[~2015-03-23 12:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 10:10 [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl Lin Ma
2015-03-23 10:10 ` [Qemu-devel] [PATCH 2/2] memory-backend: Add can_be_deleted impl for ram-backend and file-backend Lin Ma
2015-03-23 10:36 ` [Qemu-devel] [PATCH 1/2] object: Add can_be_deleted callback to TypeInfo and TypeImpl Peter Crosthwaite
2015-03-23 12:06   ` Paolo Bonzini
2015-03-23 13:13     ` Andreas Färber
2015-03-23 13:30       ` Igor Mammedov
2015-03-25 15:47         ` Lin Ma
2015-03-26 10:05           ` Igor Mammedov
2015-03-26 10:07             ` Andreas Färber
2015-03-26 10:29               ` Igor Mammedov
2015-03-26 13:37                 ` Paolo Bonzini
2015-03-26 14:18                   ` Igor Mammedov
2015-03-23 15:47     ` Lin Ma
2015-03-23 12:52 ` Andreas Färber [this message]
2015-03-23 15:25   ` Lin Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55100C94.104@suse.de \
    --to=afaerber@suse.de \
    --cc=imammedo@redhat.com \
    --cc=lma@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).