From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property
Date: Mon, 23 Mar 2015 14:19:16 +0100 [thread overview]
Message-ID: <551012D4.2070407@redhat.com> (raw)
In-Reply-To: <CAFEAcA8d769Qedntvwt7iRZ5T2F3J8ThW85-S_RK8Q7MR3VYYQ@mail.gmail.com>
On 23/03/2015 13:09, Peter Maydell wrote:
> > The only alternative for 2.3 is reverting the patch for sdhci-pci. I
> > certainly don't want "-drive if=sd -device sdhci-pci" to become ABI!
>
> What's wrong with that, incidentally? It's what I would have
> expected for connecting an SD card to sdhci-pci, given
> how the other SD controller devices work. (The only
> difference with sdhci-pci is it happens to be a
> pluggable device rather than hardwired into a board model.)
Usually, "-drive if=" options (apart from if=none) are only handled at
board creation time, and is not affected by -device. PCI devices use
"-device sdhci-pci,drive=xyz" to tie themselves to a -drive option.
Paolo
next prev parent reply other threads:[~2015-03-23 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 15:54 [Qemu-devel] [PATCH for-2.3] sdhci: add "drive" property Paolo Bonzini
2015-03-23 9:10 ` Markus Armbruster
2015-03-23 12:05 ` Paolo Bonzini
2015-03-23 12:09 ` Peter Maydell
2015-03-23 13:19 ` Paolo Bonzini [this message]
2015-03-23 13:43 ` Markus Armbruster
2015-03-23 13:35 ` Markus Armbruster
2015-03-23 13:56 ` Paolo Bonzini
2015-03-23 15:01 ` Peter Crosthwaite
2015-03-23 15:15 ` Peter Maydell
2015-03-23 15:58 ` Paolo Bonzini
2015-03-24 14:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551012D4.2070407@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).