From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya3eX-0002XY-5i for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:48:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ya3eT-0002RS-Eq for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:48:29 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:35775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ya3eT-0002RH-7w for qemu-devel@nongnu.org; Mon, 23 Mar 2015 10:48:25 -0400 Received: by wibdy8 with SMTP id dy8so49564538wib.0 for ; Mon, 23 Mar 2015 07:48:24 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <551027B5.8010803@redhat.com> Date: Mon, 23 Mar 2015 15:48:21 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1426791697-17895-1-git-send-email-jsnow@redhat.com> <1426791697-17895-3-git-send-email-jsnow@redhat.com> <20150323130330.GF9268@stefanha-thinkpad.redhat.com> <551026EA.5040401@redhat.com> In-Reply-To: <551026EA.5040401@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/4] configure: factor out supported flag check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , Stefan Hajnoczi Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, stefanha@redhat.com On 23/03/2015 15:44, John Snow wrote: >> > > I just figured there was no use in rewriting the same skeleton file > unconditionally in a loop. > > The helper is used later where we do want to regenerate the skeleton. > > If you still want me to just make it unconditional, I can, but I don't > see the point. configure doesn't really look like the best place to microoptimize. :) Paolo